Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean PodPreset docs, examples and links #26027

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Clean PodPreset docs, examples and links #26027

merged 1 commit into from
Jan 15, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 10, 2021

Closes: #25942
Closes: #25939
Closes: #23285

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 10, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2021
@netlify
Copy link

netlify bot commented Jan 10, 2021 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: a11047c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fffd6199ed8ce0008e406e0

😎 Browse the preview: https://deploy-preview-26027--kubernetes-io-master-staging.netlify.app

sftim
sftim reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tengqm
/sig service-catalog
(but OK for anyone to LGTM it)

/kind cleanup
/approve

@k8s-ci-robot k8s-ci-robot added sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@sftim
Copy link
Contributor

sftim commented Jan 13, 2021

PR #26079 is similar

@sftim sftim mentioned this pull request Jan 13, 2021
Closed
@deads2k
Copy link
Contributor

deads2k commented Jan 13, 2021 •
edited
Loading

can you remove the podpreset specific bits of content/en/examples/examples_test.go ? See https://github.com/kubernetes/website/pull/26079/files#diff-ad1c9ee33d10c3bbb104f1899366a36a7bec06a1f8b3e72520ea8eeed574c6f1L59 for example.

lgtm otherwise .

@tengqm
Copy link
Contributor Author

tengqm commented Jan 14, 2021

@deads2k will do.

@tengqm tengqm mentioned this pull request Jan 14, 2021
Merged
@kbhawkey
Copy link
Contributor

Thanks @tengqm .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e5839a21c468baf803b3a741ed17d8cd5e8781e

@k8s-ci-robot k8s-ci-robot merged commit 34e8b55 into kubernetes:master Jan 15, 2021
@noqcks noqcks mentioned this pull request Jan 18, 2021
Merged
@JacobHenner JacobHenner mentioned this pull request Feb 4, 2021
Closed
@tengqm tengqm deleted the clean-podpreset branch April 22, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@daminisatya daminisatya Awaiting requested review from daminisatya

@jessfraz jessfraz Awaiting requested review from jessfraz

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@tengqm @k8s-ci-robot @sftim @deads2k @kbhawkey