Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example tests #26086

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Fix example tests #26086

merged 1 commit into from
Feb 6, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 14, 2021

This PR updates the go.mod file so that tests of the example manifests
are run against the 1.20 branch. The missing test cases for newly added
examples are also added. To perform tests on your local machine, run the
following command on the root of your local clone:

go test k8s.io/website/content/en/examples

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from jessfraz January 14, 2021 06:03
@tengqm
Copy link
Contributor Author

tengqm commented Jan 14, 2021

/hold
This PR depends on #26027

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@netlify
Copy link

netlify bot commented Jan 14, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 06228c0

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/6002832d8146000009b1b8ec

😎 Browse the preview: https://deploy-preview-26086--kubernetes-io-master-staging.netlify.app

This PR updates the go.mod file so that tests of the example manifests
are run against the 1.20 branch. The missing test cases for newly added
examples are also added. To perform tests on your local machine, run the
following command on the root of your local clone:

```
go test k8s.io/website/content/en/examples
```
@tengqm
Copy link
Contributor Author

tengqm commented Jan 16, 2021

/hold cancel

@tengqm tengqm force-pushed the fix-example-tests branch from e0cad09 to 06228c0 Compare January 16, 2021 06:09
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2021
@celestehorgan
Copy link
Contributor

Tested locally,

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7359204c7be39380d3b4b0343c505b20fe2bbd9d

Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit c02a6c0 into kubernetes:master Feb 6, 2021
@tengqm tengqm deleted the fix-example-tests branch April 22, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants