Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove podpreset docs #26079

Closed
wants to merge 1 commit into from
Closed

remove podpreset docs #26079

wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 13, 2021

PodPresets were removed in kuberenetes 1.20. This updates the docs to remove references to them. I noticed several docs in non-english languages, I left them alone hoping that they get updated after the fact.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah after the PR has been reviewed.
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 13, 2021
@sftim sftim mentioned this pull request Jan 13, 2021
Merged
@sftim
Copy link
Contributor

sftim commented Jan 13, 2021

@deads2k, would you instead be willing to review PR #26027 which has a similar aim?

@sftim
Copy link
Contributor

sftim commented Jan 13, 2021

/sig service-catalog

@k8s-ci-robot k8s-ci-robot added the sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. label Jan 13, 2021
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 4f97126

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fff25b309a493000741fdbd

😎 Browse the preview: https://deploy-preview-26079--kubernetes-io-master-staging.netlify.app

@deads2k
Copy link
Contributor Author

deads2k commented Jan 13, 2021

@deads2k, would you instead be willing to review PR #26027 which has a similar aim?

certainly. it looks good.

@deads2k deads2k closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@jessfraz jessfraz Awaiting requested review from jessfraz

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deads2k @k8s-ci-robot @sftim