Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "schedule-eviction" to "schedule-and-eviction" #21203

Closed
wants to merge 1 commit into from
Closed

Rename "schedule-eviction" to "schedule-and-eviction" #21203

wants to merge 1 commit into from

Conversation

xinydev
Copy link
Member

@xinydev xinydev commented May 26, 2020

Rename scheduling-eviction to scheduling-and-eviction , mentioned in #19385

  • id,ja,pt: move scheduling to scheduling-and-eviction
  • en,ko,zh: move scheduling-eviction to scheduling-and-eviction

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Hsiny!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/fr Issues or PRs related to French language labels May 26, 2020
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 26, 2020
@xinydev
Copy link
Member Author

xinydev commented May 26, 2020

/assign @alculquicondor

@netlify
Copy link

netlify bot commented May 26, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7995633

https://deploy-preview-21203--kubernetes-io-master-staging.netlify.app

@alculquicondor
Copy link
Member

/lgtm
but I'm leaving some thoughts in #19081

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 26, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@xinydev
Copy link
Member Author

xinydev commented May 27, 2020

I just resolved a conflict using auto-merge

@alculquicondor
Copy link
Member

/assign @sftim

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2020
@jimangel
Copy link
Member

@Hsiny would it be possible to separate this PR into multiple PRs (one per language)? Each language has their own branching strategy and merging this as a single PR could cause conflicts.

Thanks!

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hisny, we've just recently stopped using capture shortcodes.

Would you be willing to rebase the changes in this PR against master?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sftim
You can assign the PR to them by writing /assign @sftim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xinydev
Copy link
Member Author

xinydev commented Jun 11, 2020

@Hsiny would it be possible to separate this PR into multiple PRs (one per language)? Each language has their own branching strategy and merging this as a single PR could cause conflicts.

Thanks!

@jimangel there will be almost 9 PRs, is it ok?

@hisny, we've just recently stopped using capture shortcodes.

Would you be willing to rebase the changes in this PR against master?

@sftim I have rebased the changes against master and fixed conflicts

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2020
@xinydev xinydev closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants