-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "schedule-eviction" to "schedule-and-eviction" #21203
Conversation
Welcome @Hsiny! |
/assign @alculquicondor |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7995633 https://deploy-preview-21203--kubernetes-io-master-staging.netlify.app |
/lgtm |
New changes are detected. LGTM label has been removed. |
I just resolved a conflict using auto-merge |
/assign @sftim |
@Hsiny would it be possible to separate this PR into multiple PRs (one per language)? Each language has their own branching strategy and merging this as a single PR could cause conflicts. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hisny, we've just recently stopped using capture shortcodes.
Would you be willing to rebase the changes in this PR against master?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jimangel there will be almost 9 PRs, is it ok?
@sftim I have rebased the changes against master and fixed conflicts |
Rename
scheduling-eviction
toscheduling-and-eviction
, mentioned in #19385scheduling
toscheduling-and-eviction
scheduling-eviction
toscheduling-and-eviction