Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Scheduling" concept as "Scheduling and Eviction" #19385

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Rename "Scheduling" concept as "Scheduling and Eviction" #19385

merged 1 commit into from
Apr 14, 2020

Conversation

adambkaplan
Copy link
Contributor

  • en, ja, zh, ko: move "scheduling" to "scheduling-eviction"
  • en: rename "Scheduling" to "Scheduling and Eviction"
  • Add redirects
  • Replace "scheduling" links with "scheduling-eviction"

Part of proposal #19081

Signed-off-by: Adam Kaplan [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 28, 2020
@adambkaplan
Copy link
Contributor Author

/assign @bradtopol

/cc @zacharysarah

@netlify
Copy link

netlify bot commented Feb 28, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1bb09e6

https://deploy-preview-19385--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Contributor

sftim commented Feb 29, 2020

@adambkaplan I like this idea, but it will be hard to review as-is.
Please separate this PR into an English localization change followed by separate changes for each downstream localization. The redirects should mean that downstream localizations don't have to change in lock step.

See https://kubernetes.io/docs/contribute/intermediate/#working-with-localized-content

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@kbhawkey
Copy link
Contributor

kbhawkey commented Apr 3, 2020

Hi @adambkaplan ,
Would you have time to split out the localized content from this pull request and rebase?
Thanks!

@adambkaplan adambkaplan force-pushed the schedule-eviction-1 branch from 43ccdec to 625db1b Compare April 8, 2020 01:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2020
@adambkaplan
Copy link
Contributor Author

@kbhawkey @sftim @bradtopol took me a while to get around to this. Rebased and only included the English localization.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2020
@sftim
Copy link
Contributor

sftim commented Apr 11, 2020

@adambkaplan looks like this needs another rebase. Could you rebase this again?

/remove-language fr
/remove-language ja
/remove-language ko
/remove-language pl
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pl Issues or PRs related to Polish language language/zh Issues or PRs related to Chinese language labels Apr 11, 2020
@adambkaplan
Rename "Scheduling: concept as "Scheduling and Eviction"
1bb09e6 
* Rename `docs/concepts/scheduling` to `docs/concepts/scheduling-eviction`
* Retitle concept header to "Scheduling and Eviction"
* Update redirects
* Update internal links (en only)

Part of proposal kubernetes#19081

Signed-off-by: Adam Kaplan <[email protected]>
@adambkaplan adambkaplan force-pushed the schedule-eviction-1 branch from 625db1b to 1bb09e6 Compare April 14, 2020 12:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2020
@adambkaplan
Copy link
Contributor Author

@sftim rebased again - ptal

@sftim
Copy link
Contributor

sftim commented Apr 14, 2020

/lgtm
Thanks @adambkaplan

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@zacharysarah
Copy link
Contributor

@adambkaplan Nice, thanks for this! ✨

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 77b4fa5 into kubernetes:master Apr 14, 2020
@alculquicondor
Copy link
Member

scheduling-eviction doesn't read well to me. Is having -and- in the path against any guidance?

@sftim
Copy link
Contributor

sftim commented May 25, 2020

scheduling-and-eviction would also be a valid name.

@alculquicondor
Copy link
Member

@Hsiny would you mind fixing this?

@xinydev
Copy link
Member

xinydev commented May 26, 2020

@alculquicondor ok, I will create a PR for renaming the link from scheduling-eviction to scheduling-and-eviction

@xinydev xinydev mentioned this pull request May 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuisine abuisine Awaiting requested review from abuisine

@daminisatya daminisatya Awaiting requested review from daminisatya

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@bradtopol bradtopol

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adambkaplan @sftim @kbhawkey @zacharysarah @k8s-ci-robot @alculquicondor @xinydev @bradtopol