-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing capture statements #21359
removing capture statements #21359
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 87f6871 https://deploy-preview-21359--kubernetes-io-master-staging.netlify.app |
d96deac
to
13e7365
Compare
13e7365
to
ae82f73
Compare
@kbhawkey I spotted a detail about section ordering Compare also https://kubernetes.io/fr/docs/tasks/tools/install-minikube/ and look at the What's next section ordering. The conversion is not placing the What's next “capture” last in the page. (I think this is enough to go on with; if the explanation isn't clear, I'm happy to provide screenshots / further examples). |
Thanks @sftim. The |
8295489
to
83f71f0
Compare
I just noticed that the generated component tool pages ( |
b67f313
to
87f6871
Compare
this is HUGE!!! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This addresses several problems identified in issue #20335 |
Generating pages without
capture
statements.Completed de, en, es, fr, id, it, ja, ko, pl, pt, ru, uk, vi, zh.
Removed related capture template code.
Created contribute/style/page-content-types.md
Previous testing PRs (#20977, #21253, #21277).