-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change approvers to reviewers in front matter #7432
Comments
/assign @steveperry-53 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This is meant to be the last change for issue kubernetes#7432. Closes:# 7432
#8644 is still open. /remove-lifecycle stale |
This is meant to be the last change for issue #7432. Closes:# 7432
This is a...
Problem:
In several topics, in the front matter, we have an approvers list. But we want to restrict our approvers list to people in sig-docs-maintainers. And we the people who are automatically suggested as approvers to be restricted to those in sig-docs-maintainers.
Here's an example:
In #7439, we have this suggestion for an approver:
"To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: enisoc
Assign the PR to them by writing /assign @enisoc in a comment when ready."
How is it that enisoc was suggested as an approver?
I suspect it's because enisoc is listed as an aprover in the front matter of custom-resources.md.
title: Custom Resources
approvers:
Here's another example in #7445:
"We suggest the following additional approvers: davidopp, jbeda, jcbsmpsn, justinsb, lavalamp, liggitt, nikhiljindal, random-liu, thockin
Assign the PR to them by writing /assign @davidopp @jbeda @jcbsmpsn @justinsb @lavalamp @liggitt @nikhiljindal @Random-Liu @thockin in a comment when ready."
Proposed Solution:
In the front matter, change the name of the list from approvers to reviewers.
Page to Update:
Many pages in the kubernetes.io site.
Go to /docs. grep -r approvers
The text was updated successfully, but these errors were encountered: