Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change approvers to reviewers in front matter #7432

Closed
1 of 2 tasks
steveperry-53 opened this issue Feb 17, 2018 · 3 comments
Closed
1 of 2 tasks

Change approvers to reviewers in front matter #7432

steveperry-53 opened this issue Feb 17, 2018 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@steveperry-53
Copy link
Contributor

steveperry-53 commented Feb 17, 2018

This is a...

  • Feature Request
  • Bug Report

Problem:
In several topics, in the front matter, we have an approvers list. But we want to restrict our approvers list to people in sig-docs-maintainers. And we the people who are automatically suggested as approvers to be restricted to those in sig-docs-maintainers.

Here's an example:
In #7439, we have this suggestion for an approver:
"To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: enisoc
Assign the PR to them by writing /assign @enisoc in a comment when ready."

How is it that enisoc was suggested as an approver?
I suspect it's because enisoc is listed as an aprover in the front matter of custom-resources.md.


title: Custom Resources
approvers:

  • enisoc
  • deads2k

Here's another example in #7445:
"We suggest the following additional approvers: davidopp, jbeda, jcbsmpsn, justinsb, lavalamp, liggitt, nikhiljindal, random-liu, thockin
Assign the PR to them by writing /assign @davidopp @jbeda @jcbsmpsn @justinsb @lavalamp @liggitt @nikhiljindal @Random-Liu @thockin in a comment when ready."

Proposed Solution:
In the front matter, change the name of the list from approvers to reviewers.

Page to Update:
Many pages in the kubernetes.io site.
Go to /docs. grep -r approvers

@steveperry-53
Copy link
Contributor Author

/assign @steveperry-53
/cc @heckj
/cc @chenopis
/cc @Bradamant3

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2018
tengqm added a commit to tengqm/website that referenced this issue May 21, 2018
This is meant to be the last change for issue kubernetes#7432.

Closes:# 7432
@nikhita
Copy link
Member

nikhita commented May 21, 2018

#8644 is still open.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 21, 2018
k8s-ci-robot pushed a commit that referenced this issue May 21, 2018
This is meant to be the last change for issue #7432.

Closes:# 7432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

6 participants