Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In tutorials, in front matter, change approvers to reviewers. #7440

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

steveperry-53
Copy link
Contributor

@steveperry-53 steveperry-53 commented Feb 18, 2018

Partially addresses #7432.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2018
@steveperry-53
Copy link
Contributor Author

/assign @heckj

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8b7129e

https://deploy-preview-7440--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor Author

@heckj in #7432, I added a note as to why I think the front matter approvers lists are having an effect on the suggested approvers.

@heckj
Copy link
Contributor

heckj commented Feb 18, 2018

@steveperry-53 cool - I hope you're correct. Totally good with the changes...
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit d1e8acb into kubernetes:master Feb 18, 2018
@steveperry-53 steveperry-53 deleted the approvers-reviewers-2 branch February 18, 2018 22:09
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants