Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Admin, in front matter, change approvers to reviewers. #7445

Merged
merged 1 commit into from
Feb 22, 2018
Merged

In Admin, in front matter, change approvers to reviewers. #7445

merged 1 commit into from
Feb 22, 2018

Conversation

steveperry-53
Copy link
Contributor

@steveperry-53 steveperry-53 commented Feb 18, 2018 •
edited by k8s-reviewable
Loading

Partially addresses #7432.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2018
@steveperry-53
Copy link
Contributor Author

/assign @chenopis

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 192ab0f

https://deploy-preview-7445--kubernetes-io-master-staging.netlify.com

@steveperry-53 steveperry-53 mentioned this pull request Feb 18, 2018
Closed
2 tasks
@steveperry-53
Copy link
Contributor Author

/unassign @chenopis
/assign @zacharysarah

@zacharysarah
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6630308 into kubernetes:master Feb 22, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@steveperry-53 @bsalamat
In Admin, in front matter, change approvers to reviewers. (kubernetes…
dfdafd2 
…#7445)
tehut pushed a commit to tehut/website that referenced this pull request Mar 8, 2018
@steveperry-53 @tehut
In Admin, in front matter, change approvers to reviewers. (kubernetes…
d2a35e5 
…#7445)
@steveperry-53 steveperry-53 deleted the approvers-reviewers-6 branch May 16, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudancs madhusudancs Awaiting requested review from madhusudancs

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@steveperry-53 @k8sio-netlify-preview-bot @zacharysarah @k8s-ci-robot @chenopis