krel: make promote-images work for other k8s and k8s sigs projects

[CecileRobertMichon]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes krel promote-images work with other projects so it can be used by other maintainers to promote images in k8s/k8s.io.

The default values are set to the Kubernetes project to preserve existing behavior.

Example usage:

krel promote-images --project cluster-api-azure --tag v0.5.4 --reviewers "@nader-ziada @devigned" --fork CecileRobertMichon

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

krel: make promote-images work for other k8s and k8s sigs projects

[CecileRobertMichon]

/cc @puerco

trying to find a good way to test this. Pushed a fake tag but currently, it's failing with FATA Growing manifest with tag v0.5.4: no images survived filtering; double-check your --filter_* flag(s) for typos

[CecileRobertMichon]

Pushed a fake tag but currently, it's failing with FATA Growing manifest with tag v0.5.4: no images survived filtering; double-check your --filter_* flag(s) for typos

fixed this issue

but now I'm getting

FATA pushing userfork to CecileRobertMichon/k8s.io: command /usr/local/bin/git push --set-upstream userfork cluster-api-azure-v0.5.4-image-promotion did not succeed: [email protected]: Permission denied (publickey).

checking if it's an issue with my github token...

[CecileRobertMichon]

IT WORKS 🎉

kubernetes/k8s.io#2882

I actually had an issue with my github ssh key, fixed it by following https://docs.github.com/en/authentication/troubleshooting-ssh/error-permission-denied-publickey

[CecileRobertMichon]

Few things remaining:

1. need to fix the integration test
2. could we somehow sort the images by tag instead of by SHA (maybe as an option)? IMO that's more human friendly... @puerco thoughts?
3. should the k8s.io PR not have the releng prefix when the PR isn't for kubernetes? does the release team use that for triage?

[CecileRobertMichon]

/retest

not sure if it was a flake?

time="2021-10-05T19:08:38Z" level=info msg="Hit the rate limit on try 1, sleeping for 49m58.453160242s" err="GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=10&per_page=50: 403 API rate limit of 60 still exceeded until 2021-10-05 19:58:37 +0000 UTC, not making remote request. [rate reset in 49m58s]"

[saschagrunert]

not sure if it was a flake?

Yeah, that's a flake :/

[saschagrunert]

Code lgtm

/hold

@CecileRobertMichon please remove the WIP when you're ready

[cpanato]

/lgtm
thanks Cecile!

[CecileRobertMichon]

@saschagrunert @cpanato thanks for the review! @justaugustus pointed out in Slack that we should put this in https://github.com/kubernetes-sigs/promo-tools instead. Do we want to merge this PR first and then add the functionality to promo-tools or add it there directly? Seems like promo-tools doesn't have functionality for opening an image promotion PR currently so might be a bigger chunk of work.

[saschagrunert]

Seems like promo-tools doesn't have functionality for opening an image promotion PR currently so might be a bigger chunk of work.

If that's the case then moving forward iteratively seems fine to me.

[justaugustus]

Seems like promo-tools doesn't have functionality for opening an image promotion PR currently so might be a bigger chunk of work.

If that's the case then moving forward iteratively seems fine to me.

Agreed!
Thanks for this awesome improvement, Cecile!
/lgtm
/approve
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato,justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment