Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capz: Image promotion for cluster-api-azure v1.0.0-rc.0 #2997

Merged
merged 1 commit into from
Oct 29, 2021
Merged

capz: Image promotion for cluster-api-azure v1.0.0-rc.0 #2997

merged 1 commit into from
Oct 29, 2021

Conversation

CecileRobertMichon
Copy link
Member

Image promotion for cluster-api-azure v1.0.0-rc.0
This is an automated PR generated from krel The Kubernetes Release Toolbox

/hold
cc: @devigned @nader-ziada @shysank

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2021
@CecileRobertMichon CecileRobertMichon changed the title releng: Image promotion for cluster-api-azure v1.0.0-rc.0 capz: Image promotion for cluster-api-azure v1.0.0-rc.0 Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Oct 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Oct 29, 2021
CecileRobertMichon
CecileRobertMichon commented Oct 29, 2021
View reviewed changes
k8s.gcr.io/images/k8s-staging-cluster-api-azure/images.yaml
"sha256:4b6361926a1448818023ca42b1859ba5a7b7e33b3c7682fbda4e7c74045dbb7c": ["v0.4.13"]
"sha256:6ad008e4469adbbdaaa2743648e13d82d25dbf3b9160cf03df5660c3ba32731e": ["v0.4.2"]
"sha256:8129b4385e9cad6b0c786a3f45d08c3df937cdd8d072ee84ce1a5103782cae82": ["v0.4.5"]
"sha256:82f1982f944d116f0f2258ceb313160daeb28faa4870e45411160bbb142ee8f5": ["v1.0.0-rc.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only new image in here

there is a larger diff because I used kubernetes/release#2280 to promote images automatically for the first time and the krel tool orders the images by key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before: 25 lines
after: 26 lines

Copy link
Member Author

@CecileRobertMichon CecileRobertMichon Oct 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw this is really cool, all I did to open this PR was run krel promote-images --project cluster-api-azure --tag v1.0.0-rc.0 --reviewers "@devigned @nader-ziada @shysank" --fork CecileRobertMichon (it opened the PR for me)

will integrate this directly in the capz makefile once it's included in a krel release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an images tagged with v1.0.0-rc.0 here https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/eu/cluster-api-azure/cluster-api-azure-controller

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll happen after the merge. I can see the image in staging repo https://console.cloud.google.com/gcr/images/k8s-staging-cluster-api-azure/global/cluster-api-azure-controller

@CecileRobertMichon
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@shysank
Copy link
Contributor

shysank commented Oct 29, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6e76cf1 into kubernetes:main Oct 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shysank shysank shysank left review comments

@nader-ziada nader-ziada nader-ziada left review comments

@cpanato cpanato Awaiting requested review from cpanato

@juan-lee juan-lee Awaiting requested review from juan-lee

Assignees

@shysank shysank

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@CecileRobertMichon @k8s-ci-robot @shysank @nader-ziada