Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General promote-images tool for k8s image maintainers #2279

Closed
CecileRobertMichon opened this issue Oct 5, 2021 · 3 comments
Closed

General promote-images tool for k8s image maintainers #2279

CecileRobertMichon opened this issue Oct 5, 2021 · 3 comments
Assignees
@justaugustus @CecileRobertMichon
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone
v1.23

Comments

@CecileRobertMichon
Copy link
Member

What would you like to be added:

Currently, the krel promote-images tool only works for kubernetes images. It would be great to extend it to other projects in k8s and k8s-sigs that have staging images hosted in k8s.gcr.io.

Slack thread for context: https://kubernetes.slack.com/archives/CCK68P2Q2/p1629334254082700
@CecileRobertMichon CecileRobertMichon added area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 5, 2021
@CecileRobertMichon
Copy link
Member Author

/assign

@saschagrunert saschagrunert added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority labels Oct 6, 2021
@justaugustus justaugustus added this to the v1.23 milestone Oct 23, 2021
@justaugustus
Copy link
Member

Completed in #2280, kubernetes-sigs/promo-tools#458, and kubernetes-sigs/promo-tools#460.

Docs here: https://sigs.k8s.io/promo-tools/docs/promotion-pull-requests.md

Thanks for working on this, Cecile!
/close

@justaugustus justaugustus self-assigned this Dec 13, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

Completed in #2280, kubernetes-sigs/promo-tools#458, and kubernetes-sigs/promo-tools#460.

Docs here: https://sigs.k8s.io/promo-tools/docs/promotion-pull-requests.md

Thanks for working on this, Cecile!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justaugustus justaugustus

@CecileRobertMichon CecileRobertMichon

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
v1.23
Development

No branches or pull requests
4 participants
@justaugustus @saschagrunert @CecileRobertMichon @k8s-ci-robot