switch build scripts to use go modules, stop requiring $GOPATH #82531

liggitt · 2019-09-10T13:50:36Z

aanm · 2019-09-10T14:13:30Z

fix excessive go list use in build scripts causing extremely long build times in go1.13 (go list is fast in go1.12, slow in go1.13)

@liggitt The only way I found out to keep using go list without long build times was to run with GO111MODULE=off for go lint commands.

liggitt · 2019-09-10T14:14:34Z

I think @thockin was looking into running the command once and caching/reusing the results for the remainder of the make invocation

carlosedp · 2019-09-12T13:50:54Z

I'd like to bring to attention that beginning with Go 1.13, the command go mod vendor will not include files tagged with // +build ignore so some CI validation might fail with vendor dirs created with this version.
More info on golang/go#33353 and golang/go#31088.

bcmills · 2019-09-13T14:13:01Z

go list is fast in go1.12, slow in go1.13

That may be a side-effect of the fix for golang/go#29773, since it seems that you do have a lot of dependencies through older versions from the main module (due to heketi/heketi#1648).

If the go list performance regression you're seeing is not attributable to that, then please do file an issue — I'm not aware of anything else that should have slowed it down at all.

liggitt · 2019-09-13T14:19:23Z

Hmm, maybe it wasn't that go list was slower, it was that it started having side effects, and the side-effect-free alternatives were slower. xref golang/go#31087

liggitt · 2019-09-17T19:49:10Z

heketi/heketi issue resolved in heketi/heketi#1649, vendored copy bumped in #82805

thockin · 2019-09-17T23:02:50Z

The things that call go list have to be totally rewritten.

golang/go#31087

thockin · 2019-09-17T23:05:07Z

compiling with 1.13 gives me:

$ make kubectl
go/build: importGo k8s.io/kubernetes: exit status 1
can't load package: package k8s.io/kubernetes: cannot find module providing package k8s.io/kubernetes


+++ [0917 16:03:22] Building go targets for linux/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
go: finding k8s.io/kubernetes/vendor latest
go: finding k8s.io/kubernetes/vendor/k8s.io/code-generator/cmd/deepcopy-gen latest
go: finding k8s.io/kubernetes/vendor/k8s.io latest
go: finding k8s.io/kubernetes/vendor/k8s.io/code-generator latest
go: finding k8s.io/kubernetes/vendor/k8s.io/code-generator/cmd latest
can't load package: package k8s.io/kubernetes/vendor/k8s.io/code-generator/cmd/deepcopy-gen: no matching versions for query "latest"
!!! [0917 16:03:24] Call tree:
!!! [0917 16:03:24]  1: /usr/local/google/home/thockin/src/k/kubernetes/hack/lib/golang.sh:714 kube::golang::build_some_binaries(...)
!!! [0917 16:03:24]  2: /usr/local/google/home/thockin/src/k/kubernetes/hack/lib/golang.sh:853 kube::golang::build_binaries_for_platform(...)
!!! [0917 16:03:24]  3: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0917 16:03:24] Call tree:
!!! [0917 16:03:24]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0917 16:03:24] Call tree:
!!! [0917 16:03:24]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [Makefile.generated_files:200: _output/bin/deepcopy-gen] Error 1
make: *** [Makefile:559: generated_files] Error 2

At the bottom it calls go install k8s.io/kubernetes/./vendor/k8s.io/code-generator/cmd/deepcopy-gen. I forget exactly why that prefix was needed but it was. If I remove it, it passes.

thockin · 2019-09-17T23:08:29Z

...but the build fails later:

$ make kubectl
go/build: importGo k8s.io/kubernetes: exit status 1
can't load package: package k8s.io/kubernetes: cannot find module providing package k8s.io/kubernetes


+++ [0917 16:05:28] Building go targets for linux/amd64:
    ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
go: downloading k8s.io/klog v0.4.0
go: downloading k8s.io/gengo v0.0.0-20190822140433-26a664648505
go: extracting k8s.io/klog v0.4.0
go: extracting k8s.io/gengo v0.0.0-20190822140433-26a664648505
go: downloading golang.org/x/tools v0.0.0-20190621195816-6e04913cbbac
go: extracting golang.org/x/tools v0.0.0-20190621195816-6e04913cbbac
go: finding k8s.io/gengo v0.0.0-20190822140433-26a664648505
go: finding k8s.io/klog v0.4.0
go: finding golang.org/x/tools v0.0.0-20190621195816-6e04913cbbac
F0917 16:06:34.716074  242494 main.go:82] Error: Failed making a parser: unable to add directory "k8s.io/kubernetes/vendor/k8s.io/api/admission/v1": unable to import "k8s.io/kubernetes/vendor/k8s.io/api/admission/v1": go/build: importGo k8s.io/kubernetes/vendor/k8s.io/api/admission/v1: exit status 1
go: finding k8s.io/kubernetes/vendor/k8s.io latest
go: finding k8s.io/kubernetes/vendor latest
go: finding k8s.io/kubernetes/vendor/k8s.io/api latest
go: finding k8s.io/kubernetes/vendor/k8s.io/api/admission latest
can't load package: package k8s.io/kubernetes/vendor/k8s.io/api/admission/v1: no matching versions for query "latest"

make[1]: *** [Makefile.generated_files:152: gen_deepcopy] Error 1
make: *** [Makefile:559: generated_files] Error 2

fejta · 2019-09-17T23:14:28Z

We use modules, golang1.13 (and bazel) in test-infra. The way we found to get the generators to work is to temporarily disable modules:

https://github.com/kubernetes/test-infra/blob/master/hack/update-codegen.sh#L119

Here's how kind does the same thing without bazel's help:

https://github.com/kubernetes-sigs/kind/blob/master/hack/update/generated.sh

Does GO111MODULE=off change anything?

Are we sure we need to generate code for people on the fly? We could instead ask people to call go generate explicitly when they want to regenerate things.

thockin · 2019-09-17T23:16:10Z

if we depend on people calling go generate they WILL run tests without having regenerated code. This is why we did on-the-fly in the first place

fejta · 2019-09-17T23:16:59Z

We can have presubmits catch this though, right? AKA a presubmit can regenerate and fail if anything changes.

This is how test-infra handles things. We don't generate for people, but presubmits will fail if they forget:

https://github.com/kubernetes/test-infra/tree/master/hack (see the myriad update-* and verify-*, like update-deps, update-protos, update-bazel)

It seems like go is pretty committed to making people use this pattern? It seems hard to reconcile doing anything else with the expectation that you can go get code.

For example historically we generated protos on the fly with bazel, but it caused enough annoyance that we abandoned it in favor of an update-protos.sh (and verify-protos.sh) script and checking in the .pb.go files... Paradoxically people seem a lot happier since this change, despite the need to update manually.

thockin · 2019-09-17T23:17:58Z

What a miserable experience, but I guess, maybe?

liggitt · 2019-09-17T23:48:28Z

At the bottom it calls go install k8s.io/kubernetes/./vendor/k8s.io/code-generator/cmd/deepcopy-gen. I forget exactly why that prefix was needed but it was. If I remove it, it passes.

That's where I ended up in https://github.com/liggitt/kubernetes/commits/go-1.13 as well

liggitt · 2019-09-18T01:20:29Z

The immediate motivation to get to go1.13 is for support reasons. Supported go versions last ~1 year, we're six months into go1.12, and we're about to ship k8s 1.16 and support it for ~9 months. My ideal scenario is to get a small set of changes in build/generation scripts we can pick to release-1.16 to get it into a go version supported for its lifetime.

Long term, I'm hopeful the move to go1.13 and to using modules in build scripts will let us clean out a lot of GOPATH cruft we've accumulated, though I'd expect that cleanup to be more invasive and hopefully limited to k8s 1.17 only.

liggitt · 2019-09-18T01:55:48Z

looks like simply setting GO111MODULE=off in init.sh works around the build issues... that could be a reasonable first step to validate go1.13, and consider picking back to 1.16 (not urgently, just sometime in the next few months)

SataQiu · 2019-09-23T04:12:25Z

/cc

cblecker · 2019-09-26T00:23:48Z

1.13.1 is now out

bcmills · 2019-10-03T14:33:47Z

@cblecker, note that 1.13.1 was a security release. The backports for performance regressions are slated for 1.13.2.

k8s-triage-robot · 2021-11-09T21:21:27Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

urandom2 · 2021-11-09T23:10:18Z

/remove-lifecycle stale

BenTheElder · 2021-11-09T23:23:58Z

xref: #105891

justaugustus · 2021-11-16T21:48:06Z

/milestone v1.24

jyotimahapatra · 2022-02-09T02:58:07Z

Hi 👋 . Checking in from bug triage for 1.24. Should we be tracking progress on this issue for 1.24 release?

jyotimahapatra · 2022-03-16T05:19:06Z

Hi @liggitt 👋 . I'm checking in from bug triage team. Is this issue being targeted for 1.24 milestone?

liggitt · 2022-03-16T15:06:28Z

no, will move to 1.25. go1.18 added support for go workspaces, which might be helpful here (@thockin is carving up the make logic gradually, but that will not complete in 1.24)

/milestone v1.25

thockin · 2022-04-05T23:35:46Z

Hopefully I can get more time soon so we can get this in for 25

hosseinsalahi · 2022-06-21T16:10:04Z

Hi @liggitt
My name Hossein Salahi from Bug-Triage team. I am just checking to ensure if everything is on track for K8s 1.25.
Thanks!

liggitt · 2022-06-21T16:31:58Z

I doubt it will be completed in 1.25, but some work is happening in the 1.25 timeframe (https://groups.google.com/a/kubernetes.io/g/dev/c/zcGFMru0gPU/m/h1OlbdBtAwAJ), so the milestone is still appropriate

helayoty · 2022-08-15T13:25:20Z

@liggitt 👋 the release 1.25 bug triage Lead. I'm reaching out to see the status of this Issue and if we are still targeting the current release.

…n failure go 1.12 was removed from oe-core, but currently k8s cannot be built successfully with go 1.13. See link below. kubernetes/kubernetes#82531 We need to wait for k8s to support go 1.13 and update it to latest release, as well as its depedencies. Before this is done, add back go 1.12 and use it. Signed-off-by: Chen Qi <[email protected]> Signed-off-by: Bruce Ashfield <[email protected]>

liggitt · 2024-06-07T15:21:39Z

resolved by https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/4402-go-workspaces

liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2019

k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 10, 2019

liggitt mentioned this issue Sep 10, 2019

Kubernetes-master build failing with golang-master #78845

Closed

mikedanese mentioned this issue Sep 11, 2019

keep the status error from envelope service #82543

Merged

liggitt mentioned this issue Sep 12, 2019

Bump x/sys and opencontainers/runc to support Risc-V architecture #82349

Closed

liggitt mentioned this issue Sep 12, 2019

Bump k8s libraries to 1.15.3 levels heketi/heketi#1649

Merged

liggitt mentioned this issue Sep 17, 2019

Move GetPodPriority from /scheduler/util to /api/pod #82465

Merged

liggitt mentioned this issue Sep 18, 2019

update to use go1.13.4 #82809

Merged

9 tasks

This was referenced Sep 25, 2019

Ensure that make test-e2e-node can be executed anywhere #83061

Closed

unable to 'make' in kubernetes build with go version 1.13 #83124

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2021

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2021

k8s-ci-robot modified the milestones: v1.23, v1.24 Nov 16, 2021

k8s-ci-robot modified the milestones: v1.24, v1.25 Mar 16, 2022

liggitt added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 5, 2022

liggitt mentioned this issue Apr 13, 2022

Use module mode when building/installing #109464

Merged

helayoty moved this to Pending inclusion in [sig-release] Bug Triage Jun 22, 2022

helayoty added this to [sig-release] Bug Triage Jun 22, 2022

helayoty moved this from Pending inclusion to Tracked in [sig-release] Bug Triage Jun 28, 2022

Priyankasaggu11929 added this to (Test board) Kubernetes 1.26 Enhancements Tracking Jul 16, 2022

Priyankasaggu11929 removed this from (Test board) Kubernetes 1.26 Enhancements Tracking Jul 21, 2022

liggitt removed this from the v1.25 milestone Aug 15, 2022

liggitt closed this as completed Jun 7, 2024

github-project-automation bot moved this from Tracked to Done in [sig-release] Bug Triage Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

switch build scripts to use go modules, stop requiring $GOPATH #82531

switch build scripts to use go modules, stop requiring $GOPATH #82531

liggitt commented Sep 10, 2019 •

edited

Loading

aanm commented Sep 10, 2019

liggitt commented Sep 10, 2019

carlosedp commented Sep 12, 2019

bcmills commented Sep 13, 2019

liggitt commented Sep 13, 2019

liggitt commented Sep 17, 2019

thockin commented Sep 17, 2019

thockin commented Sep 17, 2019

thockin commented Sep 17, 2019

fejta commented Sep 17, 2019

thockin commented Sep 17, 2019

fejta commented Sep 17, 2019 •

edited

Loading

thockin commented Sep 17, 2019

liggitt commented Sep 17, 2019

liggitt commented Sep 18, 2019 •

edited

Loading

liggitt commented Sep 18, 2019

SataQiu commented Sep 23, 2019

cblecker commented Sep 26, 2019

bcmills commented Oct 3, 2019

k8s-triage-robot commented Nov 9, 2021

urandom2 commented Nov 9, 2021

BenTheElder commented Nov 9, 2021

justaugustus commented Nov 16, 2021

jyotimahapatra commented Feb 9, 2022

jyotimahapatra commented Mar 16, 2022

liggitt commented Mar 16, 2022

thockin commented Apr 5, 2022

hosseinsalahi commented Jun 21, 2022

liggitt commented Jun 21, 2022

helayoty commented Aug 15, 2022

liggitt commented Jun 7, 2024

switch build scripts to use go modules, stop requiring $GOPATH #82531

switch build scripts to use go modules, stop requiring $GOPATH #82531

Comments

liggitt commented Sep 10, 2019 • edited Loading

aanm commented Sep 10, 2019

liggitt commented Sep 10, 2019

carlosedp commented Sep 12, 2019

bcmills commented Sep 13, 2019

liggitt commented Sep 13, 2019

liggitt commented Sep 17, 2019

thockin commented Sep 17, 2019

thockin commented Sep 17, 2019

thockin commented Sep 17, 2019

fejta commented Sep 17, 2019

thockin commented Sep 17, 2019

fejta commented Sep 17, 2019 • edited Loading

thockin commented Sep 17, 2019

liggitt commented Sep 17, 2019

liggitt commented Sep 18, 2019 • edited Loading

liggitt commented Sep 18, 2019

SataQiu commented Sep 23, 2019

cblecker commented Sep 26, 2019

bcmills commented Oct 3, 2019

k8s-triage-robot commented Nov 9, 2021

urandom2 commented Nov 9, 2021

BenTheElder commented Nov 9, 2021

justaugustus commented Nov 16, 2021

jyotimahapatra commented Feb 9, 2022

jyotimahapatra commented Mar 16, 2022

liggitt commented Mar 16, 2022

thockin commented Apr 5, 2022

hosseinsalahi commented Jun 21, 2022

liggitt commented Jun 21, 2022

helayoty commented Aug 15, 2022

liggitt commented Jun 7, 2024

liggitt commented Sep 10, 2019 •

edited

Loading

fejta commented Sep 17, 2019 •

edited

Loading

liggitt commented Sep 18, 2019 •

edited

Loading