Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: skip files tagged ignore in go mod vendor #31088

Closed
bcmills opened this issue Mar 27, 2019 · 2 comments
Closed

cmd/go: skip files tagged ignore in go mod vendor #31088

bcmills opened this issue Mar 27, 2019 · 2 comments
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 27, 2019 •
edited
Loading

In reviewing https://golang.org/cl/169637, I noticed that one of the larger files added in https://golang.org/cl/164623 is src/vendor/golang.org/x/text/unicode/norm/maketables.go, which is tagged // +build ignore.

Such files are never included as part of the build graph and explicitly ignored by go mod tidy (#29598), so we should filter them out, much as we already filter out test sources and data (see https://golang.org/cl/122256).

CC @jayconrod @mpvl; compare #25873; contrast #26366.
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. modules labels Mar 27, 2019
@bcmills bcmills added this to the Go1.13 milestone Mar 27, 2019
@bcmills bcmills self-assigned this Mar 27, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/172978 mentions this issue: cmd/go/internal/modcmd: skip files with the "ignore" constraint in 'go mod vendor'

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/172979 mentions this issue: {,cmd}/vendor: rerun 'go mod vendor' to prune ignored files

gopherbot pushed a commit that referenced this issue Apr 19, 2019
{,cmd/}vendor: rerun 'go mod vendor' to prune ignored files
d68ac59 
Updates #31088

Change-Id: Ia126e4e83ac5cb12c2c4151d5e5c975497598f24
Reviewed-on: https://go-review.googlesource.com/c/go/+/172979
Reviewed-by: Brad Fitzpatrick <[email protected]>
@bcmills bcmills mentioned this issue Jul 25, 2019
Open
@zikaeroh zikaeroh mentioned this issue Jul 29, 2019
Closed
@carlosedp carlosedp mentioned this issue Jul 30, 2019
Closed
@carlosedp carlosedp mentioned this issue Sep 12, 2019
Closed
10 tasks
@golang golang locked and limited conversation to collaborators Apr 18, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
2 participants
@bcmills @gopherbot