-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily use containerd from Docker packages #9346
Temporarily use containerd from Docker packages #9346
Conversation
de39a23
to
2ae373a
Compare
My knee-jerk reaction is that we should stick to the community packages; I was very happy with the work you did that reduced our dependencies on the docker.com packages, as they've bitten us repeatedly in the past. Is there a containerd issue tracking the selinux issue? |
@justinsb I was quite happy with that also and would like to keep the same direction in the future. |
@justinsb I created some PRs to address this in future releases, and change again to the community packages. Do you think it's ok to switch to Docker packages until then? |
c5f8822
to
391caf8
Compare
391caf8
to
0d44644
Compare
Both PRs for containerd were accepted and next release will be built with SELinux support. @justinsb any objections? |
0d44644
to
219a2ae
Compare
As discussed during office hours, we decided this is acceptable for a temporary solution until the next containerd release 👍 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker builds the containerd binaries differently than containerd does.
This makes possible some things like enabling SELinux, which otherwise as described in #9334 (comment).
Using containerd from the docker packages should ensure better compatibility.