Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set --selinux-enabled flag in periodic SELinux #17952

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

bertinatto
Copy link
Member

--selinux-enabled was added recently in https://github.com/kubernetes/kops/pull/9334/files.

Also, run periodic job twice a day (as per suggestion from @hakman).

CC @msau42 @hakman @rifelpet

Previously we were adding the flag to --exec-opt, which is not correct.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali June 16, 2020 09:00
@bertinatto
Copy link
Member Author

xref: kubernetes/kops#9346

@hakman
Copy link
Member

hakman commented Jun 16, 2020

This will fail until the kubernetes/kops#9346 is merged. Otherwise, LGTM.

@msau42
Copy link
Member

msau42 commented Jun 16, 2020

/approve
/hold
until change is ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@hakman
Copy link
Member

hakman commented Jun 19, 2020

Depending change was merged.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@rifelpet
Copy link
Member

/lgtm
as well.

@bertinatto
Copy link
Member Author

/hold cancel

Thanks!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit f1939df into kubernetes:master Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 19, 2020
@k8s-ci-robot
Copy link
Contributor

@bertinatto: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key sig-storage-kops-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-kops-config.yaml

In response to this:

--selinux-enabled was added recently in https://github.com/kubernetes/kops/pull/9334/files.

Also, run periodic job twice a day (as per suggestion from @hakman).

CC @msau42 @hakman @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants