Build runc with selinux support #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estesp
reviewed
Apr 13, 2020
dims
force-pushed
the
build-runc-with-selinux-support
branch
from
4c2a26d to
6c72ebe
Compare
|
Looks like an update is required due to merging the other PR |
dims
force-pushed
the
build-runc-with-selinux-support
branch
from
6c72ebe to
9004aab
Compare
|
DONE. thanks @estesp |
|
Because of the mess with protobufs and broken CI, you can rebase on master now to get a clean CI run. |
docker-ce seems to be building runc with selinux support, let us follow the same pattern here please: https://github.com/docker/docker-ce/search?p=1&q=RUNC_BUILDTAGS&unscoped_q=RUNC_BUILDTAGS Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
build-runc-with-selinux-support
branch
from
9004aab to
7a252f3
Compare
|
@estesp rebased. thanks! |
Codecov Report
@@ Coverage Diff @@
## master #4183 +/- ##
=======================================
Coverage 42.41% 42.41%
=======================================
Files 133 133
Lines 15246 15246
=======================================
Hits 6466 6466
Misses 7841 7841
Partials 939 939
Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-ce seems to be building runc with selinux support, let us follow
the same pattern here please:
https://github.com/docker/docker-ce/search?p=1&q=RUNC_BUILDTAGS&unscoped_q=RUNC_BUILDTAGS
Signed-off-by: Davanum Srinivas [email protected]