Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCE Router task #11184

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Add GCE Router task #11184

merged 1 commit into from
Apr 24, 2021

Conversation

kenji-cloudnatix
Copy link
Contributor

This commit picks up the change from the previous attempt
(#6828).

  • Add Router to GCE tasks
  • Add the HasExternalIP field to InstanceTemplate
  • Create a Router task and set HasExternalIPtofalse` when a private topology is specified.

#6827

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kenji-cloudnatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab April 7, 2021 05:39
@hakman
Copy link
Member

hakman commented Apr 7, 2021

/ok-to-test
/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet April 7, 2021 06:20
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2021
@rifelpet
Copy link
Member

rifelpet commented Apr 7, 2021

this looks good to me! Could we add an integration test for this? it may require some changes in the cloudmock directory, I can provide assistance for that if needed.

@kenji-cloudnatix
Copy link
Contributor Author

Thanks! Let me take a look. Will get back if I have any question!

@kenji-cloudnatix
Copy link
Contributor Author

Hi @rifelpet , took a while but added an integration test with a separate PR. Does the direction look good to you?

@hakman
Copy link
Member

hakman commented Apr 23, 2021

@kenji-cloudnatix I think for this should be enough to add a TF output like:
https://github.com/kubernetes/kops/tree/master/tests/integration/update_cluster/minimal_gce

@kenji-cloudnatix
Copy link
Contributor Author

Sounds good! Just updated. @hakman , @rifelpet , could you take a look again?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2021
hakman
hakman requested changes Apr 24, 2021
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenji-cloudnatix. Just a small nit, other than that looks good.
/lgtm

upup/pkg/fi/cloudup/gcetasks/instancetemplate.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2021
@hakman hakman removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2021
kenji-cloudnatix
kenji-cloudnatix commented Apr 24, 2021
View reviewed changes
Copy link
Contributor Author

@kenji-cloudnatix kenji-cloudnatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

upup/pkg/fi/cloudup/gcetasks/instancetemplate.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 24, 2021
@kenji-cloudnatix
Add GCE Router task
f37330f 
This commit picks up the change from the previous attempt
(kubernetes#6828).

- Add Router to GCE tasks
- Add the HasExternalIP field to InstanceTemplate
- Create a RouterTask and set HasExternalIP to false when
  a private topology is specified.

kubernetes#6827
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member

hakman commented Apr 24, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0d9e2e7 into kubernetes:master Apr 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 24, 2021
@kenji-cloudnatix kenji-cloudnatix mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@kenji-cloudnatix @k8s-ci-robot @hakman @rifelpet