upup: gcetasks: fix diffs in instance template and router

[nicktrav]

Use the last component of the self-url for a router's region, rather
than the full URL.

Explicitly set the boolean pointer for HasExternalIP if the interface
attached to the instance does not have an access config (i.e. has no
public internet access).

Without this patch, both the router and instance template show pending
updates, neither of which can be applied as both are immutable
resources.

Signed-off-by: Nick Travers [email protected]

[k8s-ci-robot]

Hi @nicktrav. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

/cc @rifelpet
/ok-to-test

[kenji-cloudnatix]

Hi @hakman , @rifelpet , this PR will fix a bug that I've introduced in #11184 . Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

Thanks you both @nicktrav & @kenji-cloudnatix.