Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lifecycle test for GCE #11291

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Add a lifecycle test for GCE #11291

merged 1 commit into from
Apr 27, 2021

Conversation

kenji-cloudnatix
Copy link
Contributor

  • Move MockGCECloud to cloudmock/gce.
  • Change Compute() and CloudDNS() of GCECloud to return interfaces
    for mocking

@k8s-ci-robot
Copy link
Contributor

Hi @kenji-cloudnatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2021
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/gce_integration_test branch from 46ba8eb to 3392b54 Compare April 22, 2021 23:07
@kenji-cloudnatix kenji-cloudnatix mentioned this pull request Apr 22, 2021
Merged
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/gce_integration_test branch 2 times, most recently from bdb3375 to 6f39484 Compare April 22, 2021 23:26
@hakman
Copy link
Member

hakman commented Apr 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2021
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/gce_integration_test branch from 6f39484 to fb7ac4c Compare April 23, 2021 04:58
@hakman
Copy link
Member

hakman commented Apr 24, 2021

/lgtm
/assign @rifelpet

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2021
rifelpet
rifelpet reviewed Apr 25, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for implementing this!

one nit otherwise lgtm. We can address the TODOs in followup PRs

pkg/resources/gce/gce.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/gce_integration_test branch from 5a38d49 to 74a0a1c Compare April 26, 2021 19:49
@kenji-cloudnatix
Copy link
Contributor Author

/retest

@kenji-cloudnatix
Add a lifecycle test for GCE
71f5236 
- Move MockGCECloud to cloudmock/gce.
- Change Compute() and CloudDNS() of GCECloud to return interfaces
  for mocking
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/gce_integration_test branch from 74a0a1c to 71f5236 Compare April 26, 2021 20:07
@kenji-cloudnatix
Copy link
Contributor Author

Thanks @hakman , @rifelpet ! Made a fix and rebased the PR.

@hakman
Copy link
Member

hakman commented Apr 27, 2021

Thanks @kenji-cloudnatix! :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit d443c27 into kubernetes:master Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@hakman hakman hakman approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@kenji-cloudnatix @k8s-ci-robot @hakman @rifelpet