Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy triage-party #967

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Deploy triage-party #967

merged 1 commit into from
Jun 29, 2020

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jun 16, 2020

Deploy triage-party for the release team.
This current deployment will only show a dashboard tracking all issues and PRs with the labels:
v1.19
priority/critical-urgent.

The rules added for this deployment came from https://github.com/google/triage-party/blob/v1.1.0/config/examples/kubernetes.yaml.
`

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 16, 2020
@ameukam
Copy link
Member Author

ameukam commented Jun 16, 2020

/assign @bartsmykla @spiffxp @justaugustus
cc @kubernetes/release-engineering
cc @LappleApple

/sig release
/area release-eng

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jun 16, 2020
@ameukam ameukam mentioned this pull request Jun 16, 2020
Closed
ameukam
ameukam commented Jun 16, 2020
View reviewed changes
triage-party/release-team/deployment.yaml
- name: GITHUB_TOKEN
valueFrom:
secretKeyRef:
name: triage-party-github-token
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp @justaugustus Can you add the token as a secret ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the token from @justaugustus, created a kubernetes secret, put that in secretmanager:

kubectl create secret generic triage-party-github-token --from-file token -o=yaml --dry-run \
  | gcloud secrets create --project kubernetes-public triage-party-github-token --replication-policy automatic --data-file -

Gave access to that secret to the same group that has access to this namespace:

gcloud secrets add-iam-policy-binding --project kubernetes-public triage-party-github-token --member group:[email protected] --role roles/secretmanager.admin

You can deploy this to the cluster via:

gcloud secrets versions access latest --project kubernetes-public --secret triage-party-github-token | kubectl apply -n triageparty-release -f -

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffxp Unfortunately, members of this group don't have the privileges to create secrets :

k8s.io/infra/gcp/namespaces/namespace-user-role.yml

Lines 41 to 43 in f297d82

- apiGroups: [""]
resources: ["secrets"]
verbs: ["list"]
.

Can you run the last command for us ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also opened #988 to suggest that we give members of the group the ability to create/delete read secrets for that namespace. We do that for pretty much all other namespace-scoped resources

spiffxp
spiffxp suggested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a README.md describing what this is and how to deploy it? Similar to https://github.com/kubernetes/k8s.io/blob/master/slack-infra/README.md

@ameukam
Deploy triage-party
f5bba91 
Resources needed to deploy triage-party for the release team
in the aaa cluster.
Only k/k repo will be indexed at the beginning

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Copy link
Member Author

ameukam commented Jun 29, 2020

@spiffxp README.md added

spiffxp
spiffxp approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
enough to iterate from, I will run ensure-static-ips once this merges, but leave deploying the rest of the resources to @ameukam or someone else with appropriate privileges

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1e77e34 into kubernetes:master Jun 29, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 29, 2020 

$ ./ensure-static-ips.sh
Ensure address: gcsweb-k8s-io
Ensure address: k8s-io-ingress-canary
Ensure address: k8s-io-ingress-prod
Ensure address: perf-dash-k8s-io-ingress-prod
Ensure address: slack-infra-ingress-prod
Ensure address: node-perf-dash-k8s-io-ingress-prod
Ensure address: triage-party-release-ingress-prod
Created [https://www.googleapis.com/compute/v1/projects/kubernetes-public/global/addresses/triage-party-release-ingress-prod].

@ameukam
Copy link
Member Author

ameukam commented Jun 30, 2020

Thank you!

@bartsmykla
Copy link
Contributor 

triage-party-release-ingress-prod | 35.186.239.70

@ameukam ameukam mentioned this pull request Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

@thockin thockin Awaiting requested review from thockin

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@bartsmykla bartsmykla

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @k8s-ci-robot @spiffxp @bartsmykla @justaugustus