-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow namespace-use-role access to secrets #988
Conversation
Putting this up to ask the question: why are cluster admins the only people allowed to create secrets? I personally would rather delegate control of a namespace's resource, including its secrets, to the rbac group.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
We left Secret out because we thought a) the vast vast majority of
use-cases was for TLS certs, which cert-manager handles and b) it was risky
for people to exfiltrate TLS certs for something.k8s.io.
Maybe that's overly-paranoid? It was a case of "we can add it if we need
it. I don't object to adding it back in, but it is unfortunate that we
can't easily get finer-grained than that.
…On Mon, Jun 29, 2020 at 3:33 PM Aaron Crickenberger < ***@***.***> wrote:
/hold
for comment from requested reviewers
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#988 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVEUM6BOQOOUMETF6G3RZEJFBANCNFSM4OLUYBLQ>
.
|
If we already provide |
@spiffxp do we still need this? |
/close |
@spiffxp: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Putting this up to ask the question: why are cluster admins the only
people allowed to create secrets? I personally would rather delegate
control of a namespace's resource, including its secrets, to the rbac
group.
Bumped into this while helping @ameukam setup triage-party here: https://github.com/kubernetes/k8s.io/pull/967/files#r445789688
/cc @cblecker @thockin @dims