Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow namespace-use-role access to secrets #988

Closed

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jun 29, 2020

Putting this up to ask the question: why are cluster admins the only
people allowed to create secrets? I personally would rather delegate
control of a namespace's resource, including its secrets, to the rbac
group.

Bumped into this while helping @ameukam setup triage-party here: https://github.com/kubernetes/k8s.io/pull/967/files#r445789688

/cc @cblecker @thockin @dims

Putting this up to ask the question: why are cluster admins the only
people allowed to create secrets?  I personally would rather delegate
control of a namespace's resource, including its secrets, to the rbac
group.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 29, 2020
@spiffxp spiffxp mentioned this pull request Jun 29, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Jun 29, 2020

/hold
for comment from requested reviewers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@thockin
Copy link
Member

thockin commented Jun 29, 2020 via email

@cblecker
Copy link
Member

If we already provide list, folks can already exfiltrate secrets. If we want to allow management, but not the ability to view, we could allow create/patch/delete.

@dims
Copy link
Member

dims commented Jul 26, 2020

@spiffxp do we still need this?

@spiffxp
Copy link
Member Author

spiffxp commented Aug 8, 2020

/close
I'll close this for now. If I have time I'll play around with my alternate account to confirm @cblecker's suggestion. I get the exfiltration of certs concern. Still seems like the status quo leaves us awfully bottlenecked on a few cluster admins.

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
I'll close this for now. If I have time I'll play around with my alternate account to confirm @cblecker's suggestion. I get the exfiltration of certs concern. Still seems like the status quo leaves us awfully bottlenecked on a few cluster admins.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the allow-user-role-secret-access branch March 13, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants