Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request token for google/triage-party #1903

Closed
ameukam opened this issue May 28, 2020 · 9 comments
Closed

Request token for google/triage-party #1903

ameukam opened this issue May 28, 2020 · 9 comments
Assignees
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@ameukam
Copy link
Member

ameukam commented May 28, 2020

Organization or repository

kubernetes/kubernetes

Name of integration

Triage Party

Link to integration website

https://github.com/google/triage-party

Describe what is attempting to be accomplished

SIG-Release is exploring Triage Party as a triage tool that will help the bug-triage team during release cycles. Triage Party needs a Github access token with read access.

Additional context for request

The token will be stored as a kubernetes Secret in aaa cluster where triage-party is planned to be hosted.

/assign @cblecker @spiffxp
cc @markyjackson-taulia
/sig release
/area release-eng

@ameukam ameukam added the area/github-integration Third-party integrations, webhooks, or GitHub Apps label May 28, 2020
@k8s-ci-robot
Copy link
Contributor

@ameukam: The label(s) area/release-eng cannot be applied, because the repository doesn't have them

In response to this:

Organization or repository

kubernetes/kubernetes

Name of integration

Triage Party

Link to integration website

https://github.com/google/triage-party

Describe what is attempting to be accomplished

SIG-Release is exploring Triage Party as a triage tool that will help the bug-triage team during release cycles. Triage Party needs a Github access token with read access.

Additional context for request

The token will be stored as a kubernetes Secret in aaa cluster where triage-party is planned to be hosted.

/assign @cblecker @spiffxp
cc @markyjackson-taulia
/sig release
/area release-eng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label May 28, 2020
@justaugustus
Copy link
Member

/assign
Spoke w/ @spiffxp during the GH Admin meeting. I'll pick this up.

@ameukam
Copy link
Member Author

ameukam commented Jun 3, 2020

ghproxy provide a flag (--github-api-url) that allow to override the GitHub API URL but It's only compatible with GitHub Enterprise : https://github.com/google/triage-party/blob/v1.1.0/pkg/triage/github.go#L55-L64.

We may need to patch triage-party in order to support ghproxy.

@coderanger
Copy link
Member

To copy a conclusion from Slack, triage-party has its own persistence layer so we can probably skip ghproxy for now. So next step would probably be a test deployment against a smaller repo with test token?

@ameukam
Copy link
Member Author

ameukam commented Jun 16, 2020

Link of the conclusion from Slack: https://kubernetes.slack.com/archives/C1TU9EB9S/p1591822629213000?thread_ts=1591822021.211300&cid=C1TU9EB9S.

@coderanger Something more ambitious: Running triage-party again the ĸubernetes/kubernetes repo: kubernetes/k8s.io#967. :-)

@tstromberg
Copy link
Contributor

@coderanger - Hi! I'm the author of triage-party. I believe that --github-api-url may still work for ghproxy, if the go-github API docs are to be believed: https://pkg.go.dev/github.com/google/go-github/v32/github?tab=doc#NewEnterpriseClient

If you run into any issues or have questions getting Triage Party setup, please let me know (@tstromberg on Kubernetes Slack).

@justaugustus
Copy link
Member

Created https://github.com/k8s-triage-party-sig-release-bot and generated a token with public_repo OAuth scope (ref: google/triage-party@e4b59f2).

Handed that token off to @spiffxp for deployment.
The deployment is tracked in kubernetes/k8s.io#967.

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

Created https://github.com/k8s-triage-party-sig-release-bot and generated a token with public_repo OAuth scope (ref: google/triage-party@e4b59f2).

Handed that token off to @spiffxp for deployment.
The deployment is tracked in kubernetes/k8s.io#967.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-integration Third-party integrations, webhooks, or GitHub Apps sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

7 participants