Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Slackin, as it is being bypassed #4112

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Remove Slackin, as it is being bypassed #4112

merged 1 commit into from
Aug 19, 2022

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Aug 19, 2022

Remove the Slackin app from our cloud, since it's broken and is now being completely bypassed. No need to waste the CPU cycles.

attn: @ameukam @dims

@jberkus
Remove Slackin, as it is being bypassed
774dac0 
and is no longer our slack inviter.

Signed-off-by: Josh Berkus <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 19, 2022
@k8s-ci-robot k8s-ci-robot added area/apps Application management, code in apps/ area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 19, 2022
@jberkus jberkus mentioned this pull request Aug 19, 2022
Closed
@ameukam
Copy link
Member

ameukam commented Aug 19, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, jberkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@dims
Copy link
Member

dims commented Aug 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit c30dd96 into kubernetes:main Aug 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 19, 2022
This was referenced Aug 30, 2022
Merged
Merged
@BenTheElder
Copy link
Member

manually deleted these from the cluster as the auto-deploy just kubectl apply, also dropped from ingress in #4159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@rajula96reddy rajula96reddy Awaiting requested review from rajula96reddy

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra area/apps Application management, code in apps/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@jberkus @ameukam @k8s-ci-robot @dims @BenTheElder