Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move slack tools to their own subdomain so they don't conflict with the inviter redirect #4156

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

BenTheElder
Copy link
Member

Should be easier to manage going forward, see:

I spoke to katharine about reconfiguring the apps to point to this seperate domain, we can do that once this is deployed.

TODO (follow-up):

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/apps Application management, code in apps/ labels Aug 30, 2022
@k8s-ci-robot k8s-ci-robot requested review from jeefy and thockin August 30, 2022 20:28
@k8s-ci-robot k8s-ci-robot added area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Aug 30, 2022
@dims
Copy link
Member

dims commented Aug 30, 2022

/approve
/lgtm
/hold please remove hold when ready @BenTheElder

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@ameukam
Copy link
Member

ameukam commented Aug 30, 2022

the certificate controller might not be able to create the certificate after the PR is merged. Safe approach is to deploy the DNS before the certificate.

/lgtm
/hold

Remove the hold when ready.

@BenTheElder
Copy link
Member Author

I'll deploy DNS then let this merge, working on that now

@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 30, 2022

taking a bit, had to refresh myself on this first, dns push is running but pretty slowly ...

@BenTheElder
Copy link
Member Author

DNS is live
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2fc2591 into kubernetes:main Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 30, 2022
@BenTheElder BenTheElder deleted the slack-tools branch August 30, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apps/slack-infra slack.k8s.io, slack-infra, code in apps/slack-infra area/apps Application management, code in apps/ area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants