Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace slack.k8s.io with redirect #4099

Closed
jberkus opened this issue Aug 17, 2022 · 11 comments
Closed

Replace slack.k8s.io with redirect #4099

jberkus opened this issue Aug 17, 2022 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Milestone

Comments

@jberkus
Copy link
Contributor

jberkus commented Aug 17, 2022

Infra,

We need to shut down the app (slackin) currently running at slack.k8s.io, and replace it with a redirect to https://communityinviter.com/apps/kubernetes/community. It's not clear to me how to do this, particularly with TLS.

Alternately, if that's going to be very painful, we can embed an inviter widget into a simple web page, and run that in the place of Slackin as an app.

What's the best course?

@ameukam @mrbobbytables @cblecker @nikhita

@jberkus jberkus added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Aug 17, 2022
@BenTheElder
Copy link
Member

we have a redirector service at go.k8s.io (it's an nginx instance + GKE managed TLS certs / loadbalancer, config is in this repo), we could do the same thing here.

@ameukam
Copy link
Member

ameukam commented Aug 18, 2022

To be more specific to what Ben said:

  • Ensure slack.k8s.io go to redirect.k8s.io in the DNS config
  • Ensure the nginx instance has the configuration to handle the redirection
  • Ensure slack.k8s.io is an entry in the k8s.io wildcard certificate instead of a dedicated TLS certificate

@dims
Copy link
Member

dims commented Aug 18, 2022

@ameukam one thing i was not sure about was - what to do with

- slack.k8s.io
- slack.kubernetes.io

@dims
Copy link
Member

dims commented Aug 18, 2022

Also i am not very sure about the steps for deploying #4105 - does one of you (@ameukam or @cblecker) want to please deploy?

@ameukam
Copy link
Member

ameukam commented Aug 18, 2022

/milestone v1.26
/priority critical-urgent
/kind feature

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 18, 2022
@ameukam
Copy link
Member

ameukam commented Aug 18, 2022

@ameukam one thing i was not sure about was - what to do with

- slack.k8s.io
- slack.kubernetes.io

This is need to be manually deployed after the PR is merged and the DNS entry is distributed

@ameukam
Copy link
Member

ameukam commented Aug 19, 2022

This is done.

❯ http -h https://slack.k8s.io
HTTP/1.1 301 Moved Permanently
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
Content-Length: 162
Content-Type: text/html
Date: Fri, 19 Aug 2022 13:11:35 GMT
Location: https://communityinviter.com/apps/kubernetes/community
Server: nginx
Via: 1.1 google

@jberkus can we consider this done ?

@dims
Copy link
Member

dims commented Aug 19, 2022

@jberkus here's the set of urls we tested.

http://slack.kubernetes.io/  - WORKS
https://slack.kubernetes.io/ - WORKS
http://slack.k8s.io/         - WORKS
https://slack.k8s.io/        - WORKS

@jberkus
Copy link
Contributor Author

jberkus commented Aug 19, 2022

This looks done. I'll add removing the slackin app as a follow-up for me.

/close

@k8s-ci-robot
Copy link
Contributor

@jberkus: Closing this issue.

In response to this:

This looks done. I'll add removing the slackin app as a follow-up for me.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jberkus
Copy link
Contributor Author

jberkus commented Aug 19, 2022

Follow-up: #4112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Development

No branches or pull requests

5 participants