-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace slack.k8s.io with redirect #4099
Comments
we have a redirector service at go.k8s.io (it's an nginx instance + GKE managed TLS certs / loadbalancer, config is in this repo), we could do the same thing here. |
To be more specific to what Ben said:
|
@ameukam one thing i was not sure about was - what to do with k8s.io/apps/slack-infra/resources/certificate.yaml Lines 7 to 8 in c1f58df
|
/milestone v1.26 |
This is need to be manually deployed after the PR is merged and the DNS entry is distributed |
This is done.
@jberkus can we consider this done ? |
@jberkus here's the set of urls we tested.
|
This looks done. I'll add removing the slackin app as a follow-up for me. /close |
@jberkus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Follow-up: #4112 |
Infra,
We need to shut down the app (slackin) currently running at slack.k8s.io, and replace it with a redirect to https://communityinviter.com/apps/kubernetes/community. It's not clear to me how to do this, particularly with TLS.
Alternately, if that's going to be very painful, we can embed an inviter widget into a simple web page, and run that in the place of Slackin as an app.
What's the best course?
@ameukam @mrbobbytables @cblecker @nikhita
The text was updated successfully, but these errors were encountered: