artifacts: Update manifests to use file promotion service account #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This was referenced Sep 10, 2021
|
(Working on a fix for the test failure in kubernetes-sigs/promo-tools#417) |
|
/test pull-k8sio-file-promo |
1 similar comment
|
/test pull-k8sio-file-promo |
Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
force-pushed
the
file-promo-svc-acct
branch
from
bd742a9 to
1723970
Compare
|
Presubmit passing, now that kubernetes-sigs/promo-tools#420 has been integrated. cc: @kubernetes/release-engineering |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Failed on postsubmit: ********** START **********
level=info msg="processing destination \"gs://k8s-artifacts-prod/binaries/kops/\""
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-artifacts-prod/binaries/kops/\": cannot execute a production file promotion without a service account" Pushed a fix here: kubernetes-sigs/promo-tools#422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A service account for file promotion was created in #2700, so let's utilize it in the existing manifests.
Signed-off-by: Stephen Augustus [email protected]
/assign @spiffxp @ameukam @justinsb
cc: @kubernetes/release-engineering @kubernetes/kops-maintainers
(I expect the file promotion presubmit to fail, since it's not running in a trusted env.)