Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filepromoter: Warn on (but don't block) unauthenticated operations #417

Merged
merged 2 commits into from
Sep 10, 2021
Merged

filepromoter: Warn on (but don't block) unauthenticated operations #417

merged 2 commits into from
Sep 10, 2021

Conversation

justaugustus
Copy link
Contributor

@justaugustus justaugustus commented Sep 10, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

(Part of kubernetes/k8s.io#2624, #413.)

  • filepromoter: Warn on (but don't block) unauthenticated operations
    This is a partial revert of a previous commit (kpromo: Improve service account usage/retrieval #412) which enforced
    authentication for operations on destination filestores. Without
    this, presubmits will fail because they're running in an untrusted
    environment (without access to the prod file promotion svc acct).
  • kpromo: Build v0.2.2-1 image

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Special notes for your reviewer:

Example presubmit failure from kubernetes/k8s.io#2704 (also visible in kubernetes/k8s.io#2663):

level=warning msg="failed to get service-account-token for \"[email protected]\": command /usr/bin/gcloud auth --account=k8s-infra-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token did not succeed: ERROR: (gcloud.auth.print-access-token) Your current active account [[email protected]] does not have any valid credentials\nPlease run:\n\n  $ gcloud auth login\n\nto obtain new credentials.\n\nFor service account, please activate it first:\n\n  $ gcloud auth activate-service-account ACCOUNT\n"
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-artifacts-prod/binaries/kops/\": error listing objects in \"gs://k8s-artifacts-prod/binaries/kops/\": Get \"https://storage.googleapis.com/storage/v1/b/k8s-artifacts-prod/o?alt=json&delimiter=&endOffset=&pageToken=&prefix=binaries%2Fkops%2F&prettyPrint=false&projection=full&startOffset=&versions=false\": command /usr/bin/gcloud auth --account=k8s-infra-promoter@k8s-artifacts-prod.iam.gserviceaccount.com print-access-token did not succeed: ERROR: (gcloud.auth.print-access-token) Your current active account [[email protected]] does not have any valid credentials\nPlease run:\n\n  $ gcloud auth login\n\nto obtain new credentials.\n\nFor service account, please activate it first:\n\n  $ gcloud auth activate-service-account ACCOUNT\n"

With this PR, we should see logs similar to this in presubmit:

❯ time ~/go/bin/kpromo run files --manifests=artifacts
********** START (DRY RUN) **********
INFO processing destination "gs://k8s-artifacts-prod/binaries/kops/"
WARN a service account was not specified for this filestore (gs://k8s-staging-kops/kops/releases/), so all operations will run without authentication
WARN a service account was not specified for this filestore (gs://k8s-artifacts-prod/binaries/kops/), so all operations will run without authentication
INFO listing files in bucket k8s-staging-kops with prefix "kops/releases/"
INFO listing files in bucket k8s-artifacts-prod with prefix "binaries/kops/"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/darwin/amd64/kops"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/darwin/amd64/kops.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/dns-controller-amd64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/dns-controller-amd64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/dns-controller-arm64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/dns-controller-arm64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/images.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/images.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kops-controller-amd64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kops-controller-amd64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kops-controller-arm64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kops-controller-arm64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kube-apiserver-healthcheck-amd64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kube-apiserver-healthcheck-arm64.tar.gz"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/channels"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/channels.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/kops"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/kops.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/nodeup"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/nodeup.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/protokube"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/amd64/protokube.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/channels"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/channels.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/kops"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/kops.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/nodeup"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/nodeup.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/protokube"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/linux/arm64/protokube.sha256"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/windows/amd64/kops.exe"
INFO metadata match for "gs://k8s-artifacts-prod/binaries/kops/1.21.1/windows/amd64/kops.exe.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/darwin/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/darwin/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/darwin/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/darwin/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/darwin/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/darwin/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/darwin/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/darwin/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/dns-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/dns-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/dns-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/dns-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/dns-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/dns-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/dns-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/dns-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/images.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/images.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/images.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/images.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kops-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kops-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kops-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kops-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kops-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kops-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kops-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kops-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kube-apiserver-healthcheck-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kube-apiserver-healthcheck-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kube-apiserver-healthcheck-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kube-apiserver-healthcheck-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/amd64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/amd64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/linux/arm64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/linux/arm64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/windows/amd64/kops.exe" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/windows/amd64/kops.exe"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-alpha.2/windows/amd64/kops.exe.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-alpha.2/windows/amd64/kops.exe.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/darwin/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/darwin/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/darwin/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/darwin/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/darwin/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/darwin/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/darwin/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/darwin/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/dns-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/dns-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/dns-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/dns-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/dns-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/dns-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/dns-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/dns-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/images.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/images.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/images.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/images.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kops-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kops-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kops-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kops-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kops-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kops-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kops-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kops-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kube-apiserver-healthcheck-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kube-apiserver-healthcheck-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kube-apiserver-healthcheck-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kube-apiserver-healthcheck-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/amd64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/amd64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/linux/arm64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/linux/arm64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/windows/amd64/kops.exe" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/windows/amd64/kops.exe"
COPY "gs://k8s-staging-kops/kops/releases/1.22.0-beta.1/windows/amd64/kops.exe.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.22.0-beta.1/windows/amd64/kops.exe.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/darwin/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/darwin/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/darwin/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/darwin/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/darwin/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/darwin/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/darwin/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/darwin/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/dns-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/dns-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/dns-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/dns-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/dns-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/dns-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/dns-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/dns-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/images.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/images.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/images.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/images.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kops-controller-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kops-controller-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kops-controller-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kops-controller-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kops-controller-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kops-controller-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kops-controller-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kops-controller-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kube-apiserver-healthcheck-amd64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kube-apiserver-healthcheck-amd64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kube-apiserver-healthcheck-amd64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kube-apiserver-healthcheck-arm64.tar.gz" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kube-apiserver-healthcheck-arm64.tar.gz"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/images/kube-apiserver-healthcheck-arm64.tar.gz.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/amd64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/amd64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/channels" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/channels"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/channels.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/channels.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/kops" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/kops"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/kops.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/kops.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/nodeup" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/nodeup"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/nodeup.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/nodeup.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/protokube" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/protokube"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/linux/arm64/protokube.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/linux/arm64/protokube.sha256"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/windows/amd64/kops.exe" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/windows/amd64/kops.exe"
COPY "gs://k8s-staging-kops/kops/releases/1.23.0-alpha.1/windows/amd64/kops.exe.sha256" to "gs://k8s-artifacts-prod/binaries/kops/1.23.0-alpha.1/windows/amd64/kops.exe.sha256"
********** FINISHED (DRY RUN) **********

Does this PR introduce a user-facing change?

- filepromoter: Warn on (but don't block) unauthenticated operations
  This is a partial revert of a previous commit which enforced
  authentication for operations on destination filestores. Without
  this, presubmits will fail because they're running in an untrusted
  environment (without access to the prod file promotion svc acct).
- kpromo: Build v0.2.2-1 image

@justaugustus
filepromoter: Warn on (but don't block) unauthenticated operations
6d1ba19 
This is a partial revert of a previous commit which enforced
authentication for operations on destination filestores. Without
this, presubmits will fail because they're running in an untrusted
environment (without access to the prod file promotion svc acct).

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2021
@k8s-ci-robot k8s-ci-robot requested a review from listx September 10, 2021 22:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@justaugustus
kpromo: Build v0.2.2-1 image
32c3c59 
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus justaugustus changed the title [WIP] filepromoter: Warn on (but don't block) unauthenticated operations filepromoter: Warn on (but don't block) unauthenticated operations Sep 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2021
@justaugustus
Copy link
Contributor Author

/assign @puerco @ameukam @Verolop @cpanato @saschagrunert
cc: @kubernetes-sigs/release-engineering

@puerco
Copy link
Member

puerco commented Sep 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2021
@justaugustus justaugustus mentioned this pull request Sep 10, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 24cffa0 into kubernetes-sigs:master Sep 10, 2021
This was referenced Sep 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listx listx Awaiting requested review from listx

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@justaugustus @k8s-ci-robot @puerco @saschagrunert @Verolop @ameukam @cpanato