Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filepromoter: Build unauthenticated client for source filestores #422

Merged
merged 2 commits into from
Sep 12, 2021

Conversation

justaugustus
Copy link
Contributor

@justaugustus justaugustus commented Sep 12, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

(Part of kubernetes/k8s.io#2624, #413.)

  • filepromoter: Build unauthenticated client for source filestores

    Source filestores are (supposed to be) world-readable, so there is
    no need to require an authenticated client for them.

    This is a workaround for the fact that service accounts are stored
    as part of filestore, when ergonomically, they should probably be
    at the top-level of a root promotion manifest. To be fixed in a
    future commit.

  • kpromo: Build v0.2.4-1 image

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @ameukam @cpanato @Verolop
cc: @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Discovered in https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-file-promo/1437091170512539648, following the merge of kubernetes/k8s.io#2704:

********** START **********
level=info msg="processing destination \"gs://k8s-artifacts-prod/binaries/kops/\""
level=fatal msg="run `kpromo run files`: error building operations: error building promotion operations for \"gs://k8s-artifacts-prod/binaries/kops/\": cannot execute a production file promotion without a service account" 

Does this PR introduce a user-facing change?

- filepromoter: Build unauthenticated client for source filestores
  
  Source filestores are (supposed to be) world-readable, so there is
  no need to require an authenticated client for them.

  This is a workaround for the fact that service accounts are stored
  as part of `filestore`, when ergonomically, they should probably be
  at the top-level of a root promotion manifest. To be fixed in a
  future commit.

- kpromo: Build v0.2.4-1 image

Source filestores are (supposed to be) world-readable, so there is
no need to require an authenticated client for them.

This is a workaround for the fact that service accounts are stored
as part of `filestore`, when ergonomically, they should probably be
at the top-level of a root promotion manifest. To be fixed in a
future commit.

Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 12, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,puerco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants