filepromoter: Build unauthenticated client for source filestores #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
(Part of kubernetes/k8s.io#2624, #413.)
filepromoter: Build unauthenticated client for source filestores
Source filestores are (supposed to be) world-readable, so there is
no need to require an authenticated client for them.
This is a workaround for the fact that service accounts are stored
as part of
filestore
, when ergonomically, they should probably beat the top-level of a root promotion manifest. To be fixed in a
future commit.
kpromo: Build v0.2.4-1 image
Signed-off-by: Stephen Augustus [email protected]
/assign @puerco @ameukam @cpanato @Verolop
cc: @kubernetes-sigs/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Discovered in https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-k8sio-file-promo/1437091170512539648, following the merge of kubernetes/k8s.io#2704:
Does this PR introduce a user-facing change?