Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tracing libraries for opentracing 1.6.0 #6936

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

timmysilv
Copy link
Contributor

@timmysilv timmysilv commented Mar 5, 2021

What this PR does / why we need it:

This updates the opentracing C++ library to version 1.6.0 which has been available for a while. It also updates nginx-opentracing to 0.11.0, and each tracing client to the latest version that supports opentracing-cpp v1.6.0. Note that the zipkin client does not have a tagged release yet so I'm using a commit hash for now. Also, the datadog library is still on a branch. I will update this PR once DataDog/dd-opentracing-cpp#163 is merged, tagged and released.

This is helpful because there are plenty of new features in the latest opentracing version, as well as some of the tracing clients (that now depend on the new opentracing C++ library).

Notes:

  • I removed -DWITH_BOOST_STATIC since it was unused
  • I will update the libraries in this PR as they come out
  • Once this is approved, can a maintainer run cloudbuild and update the base image?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

I did some preliminary load testing to prepare for jaegertracing/jaeger-client-cpp#255, but I will do more with this exact image.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @timmysilv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2021
@aledbf
Copy link
Member

aledbf commented Mar 9, 2021

Build an image locally

cd images/nginx

TAG=<some tag> REGISTRY=<some personal container registry> PLATFORMS=amd64 make push

Once the image is published, open a new pull request, changing the base image defined in the Makefile
and increasing the version in the TAG file

with these two changes, the e2e tests will run, ensuring the upgrade didn't break anything (covered with tests 😉)

If e2e tests pass, the NGINX PR can be merged. After ~3 hours, a new image will be available in the staging repository.

cc @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2021
remove unused boost_static option
@timmysilv
Copy link
Contributor Author

There were lots of dependency issues, deep down a rabbit hole mostly related to the jaeger client. As a fix, I propose we build and install yaml-cpp locally, then kinda hack the jaeger client's CMakeLists.txt to not build it via sed. e2e tests are passing, and everything built fine.

@ElvinEfendi
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2021
@ElvinEfendi
Copy link
Member

Since the e2e tests are passing as shown in #6956

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, timmysilv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8baef76 into kubernetes:master Mar 24, 2021
@timmysilv timmysilv deleted the update-tracing branch April 9, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants