-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tracing libraries for opentracing 1.6.0 #6936
Conversation
Hi @timmysilv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9ff67e1
to
ca7685c
Compare
Build an image locally cd images/nginx
TAG=<some tag> REGISTRY=<some personal container registry> PLATFORMS=amd64 make push Once the image is published, open a new pull request, changing the base image defined in the Makefile with these two changes, the e2e tests will run, ensuring the upgrade didn't break anything (covered with tests 😉) If e2e tests pass, the NGINX PR can be merged. After ~3 hours, a new image will be available in the staging repository. cc @ElvinEfendi |
ca7685c
to
d90ffe5
Compare
remove unused boost_static option
d90ffe5
to
b48804c
Compare
There were lots of dependency issues, deep down a rabbit hole mostly related to the jaeger client. As a fix, I propose we build and install |
b48804c
to
7f82b26
Compare
/ok-to-test |
7f82b26
to
5794a93
Compare
Since the e2e tests are passing as shown in #6956 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, timmysilv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This updates the opentracing C++ library to version 1.6.0 which has been available for a while. It also updates nginx-opentracing to 0.11.0, and each tracing client to the latest version that supports opentracing-cpp v1.6.0. Note that the zipkin client does not have a tagged release yet so I'm using a commit hash for now. Also, the datadog library is still on a branch. I will update this PR once DataDog/dd-opentracing-cpp#163 is merged, tagged and released.
This is helpful because there are plenty of new features in the latest opentracing version, as well as some of the tracing clients (that now depend on the new opentracing C++ library).
Notes:
-DWITH_BOOST_STATIC
since it was unusedTypes of changes
Which issue/s this PR fixes
How Has This Been Tested?
I did some preliminary load testing to prepare for jaegertracing/jaeger-client-cpp#255, but I will do more with this exact image.
Checklist: