-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nginx base image, handle jaeger propagation format #6956
Conversation
Hi @timmysilv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
the downgrade of Alpine to 3.10 was needed to avoid a segfault in the new jaeger-cpp-client, but modsecurity seems to not be backwards compatible. I formerly thought the Jaeger issue was compatibility, but I now think something's actually wrong with some of the new yaml parsing. I'm going to look deeper into the function in the Jaeger client then come back here. |
e0c26e5
to
b7c2fca
Compare
^ shows that e2e passes for #6936 to be approved. Manuel's comment suggests that this means the other PR can be merged, then a new image will be auto-released. I'll update the Makefile in this PR to use that resulting image. The jaeger code changes are to support the new Jaeger client configuration features available with the new base image. |
/ok-to-test |
6ead463
to
8811301
Compare
The PR is doing more than just updating the base image, is that intentional? |
yes, I alluded to that in the above comment. The new base image updates the jaeger client which handles the new propagation parameter. It can be separated into a different PR if you prefer, but the |
217d738
to
afcf7c9
Compare
adding default, testing w3c traceparent is propagated
afcf7c9
to
71c8ef1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, timmysilv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Rel #6936
Updating the nginx base image to create a new one in the staging env.