Update to opentracing-cpp v1.6.0 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tracer has been pinned to opentracing-cpp v1.5.1 for a while, despite v1.6.0 being released.
Although a branch was created that worked with 1.6.0, it wasn't easily discoverable or kept updated.
There were a few API differences between those versions that caused incompatiblity, and that'd require this tracer to maintain multiple release branches (one for v1.5.1 and another for v1.6.0).
Since functionality is relatively stable at the moment, it's more practical to maintain these versions in parallel, and backport changes as-needed to release branches.
So this PR updates the tracer to use opentracing-cpp v1.6.0, implementing additional (and useful!) methods.
Some further changes were necessary to fix outdated integration tests for nginx, and temporarily pin the docker image used for testing to an image that uses v1.6.0 as well. This will need updating again in the future.
Docs will also be updated in a separate PR before releasing this, to explain which tracer version to use to match opentracing-cpp version, and a deprecation schedule.
Fixes #115