initialize go module file

[lavalamp]

No description provided.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lavalamp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lavalamp]

Half of #143.

[lavalamp]

Ran go mod tidy & updated.

[liggitt]

should this bump Travis.yml to go1.12 and run with GO111MODULE=on to make sure CI is actually testing with the versions listed here?

xref https://github.com/kubernetes/client-go/pull/582/files

[andreykaipov]

Oh I was recently trying to get gengo to use Go modules too! 😄

To get the tests to pass (specifically TestImportBuildPackage from parser/local_parse_test.go), we have to add an empty go.mod to vendor/fake/dep:

module _

go 1.12

And reference it from the root go.mod:

module k8s.io/gengo

go 1.12

require (
        fake/dep v0.0.0
        ...
)

replace fake/dep v0.0.0 => ./vendor/fake/dep

In addition, because of an assumption the library took for importing packages (see parser/parse.go#551), we have to use $(go list k8s.io/gengo/...) instead of k8s.io/gengo/... directly for the second stage of the CI when verifying the examples (see .travis.yml#L16).

The long-term solution would be to migrate from go/build to golang.org/x/tools/go/packages as recommended by the Go 1.11 release notes https://golang.org/doc/go1.11#gopackages. The way I understand it is by invoking go list ourselves, we're essentially doing what go/packages would do for us.

edit: Oh! Also the Makefiles for each example will now have to reference the boilerplate header directly since the default location for that is in the GOPATH (args/args.go#L45).

If you'd like @lavalamp I can submit a PR into your branch with the changes described above 😄

[lavalamp]

@andreykaipov Sure, that'd be great!

[estroz]

@andreykaipov are you working on replacing go/build with golang.org/x/tools/go/packages? If not I can take a stab at it.

[andreykaipov]

Hi @estroz - I'm not working on it. At the time of my comment I tried to do it but couldn't really wrap my head around it. 😅

The only PR I have is the one above into this branch to get the CI working with Go modules, but that might have to change if go/build is replaced.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.