Consider decoupling package->directory lookups from $PWD

[jmillikin-stripe]

Branching discussion from kubernetes/repo-infra#19

Gengo currently assumes that a package "k8s.io/foo/bar" can always be found in ${PWD}/k8s.io/foo/bar/, and becomes very unhappy if the generator program is called from a different directory. This makes its use from Bazel rules complicated, and requires Kubernetes BUILD files to use custom logic such as go_genrule() instead of Bazel's built-in genrule().

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[thockin]

/lifecycle frozen Can you show a more complete repro case?

…

On Sun, Dec 31, 2017 at 2:09 AM, fejta-bot ***@***.***> wrote: Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Prevent issues from auto-closing with an /lifecycle frozen comment. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or @fejta. /lifecycle stale — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#64 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVH9bm9fx9gr4EboWcdA3aqFHYKJbks5tF11jgaJpZM4ORdSv> .

[jmillikin-stripe]

See def _compute_genrule_command(ctx): in the linked patch for a more complete comment, and to see how gengo is being invoked.

Bazel assumes that the build steps it runs are insensitive to the current working directory. For Gengo this isn't true, it expects certain Go packages to be located at particular parts of the filesystem as resolved relative to $PWD. As a result, the Kubernetes build scripts need to define their own genrule-like wrapper to set up a Gengo-compliant environment.

(I don't have full context any more since this was filed months ago as a side-effect of some other yak hunt)

[nikhita]

/remove-lifecycle stale

[estroz]

This directly relates to parsing non-GOPATH repos: #144 (comment)

[thockin]

Will be fixed in v2 (#259)