Update for go modules

[lavalamp]

Let's begin publishing the module file.

Let's version this thing and start respecting the semver guarantees.

[lavalamp]

I'd like to tag v1.0.0 after merging #144. Any objections? I think this commits us to not breaking go interfaces. @sttts @thockin

[liggitt]

I think we need a tool to tell us if we're breaking go interfaces or we'll fail at manual inspection/enforcement

I assume this applies not only to the code in this repo but also to the code generated by what is in this repo?

Is the plan to use semantic import tagging for v2 and up?

[lavalamp]

good point, I thought I heard something about the go team providing such a tool?

I guess we should also not break the code the samples generate. Maybe we should put the samples in different modules. If we check in the generated code, we could use the above tool to verify this.

Is the plan to use semantic import tagging for v2 and up?

I am not sure I understand this question, I thought for v2 we actually have to have a v2 in the path, but for v1 we shouldn't. I wasn't planning on thinking about this until someone wants to break the interface :)

[liggitt]

I thought I heard something about the go team providing such a tool?

https://github.com/golang/go/tree/master/api was all I found, but it seems hard-coded to golang src, so would require forking to use against something else

I am not sure I understand this question, I thought for v2 we actually have to have a v2 in the path, but for v1 we shouldn't.

correct

I wasn't planning on thinking about this until someone wants to break the interface :)

fair

[liggitt]

good point, I thought I heard something about the go team providing such a tool?

I also saw https://github.com/smola/gocompat mentioned (kubernetes/client-go#234 (comment)), but ran into issues trying to run it on our repos

[liggitt]

I think https://github.com/golang/tools/tree/master/internal/apidiff is the tool in the works from the go team

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lavalamp]

/reopen /lifecycle frozen

…

On Mon, Sep 9, 2019 at 4:05 PM Kubernetes Prow Robot < ***@***.***> wrote: @fejta-bot <https://github.com/fejta-bot>: Closing this issue. In response to this <#143 (comment)>: Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /close Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#143?email_source=notifications&email_token=AAE6BFQNH3Z3O22Z3XEN2ILQI3JC3A5CNFSM4HDWZDFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6JJNOA#issuecomment-529700536>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE6BFRNUQ2ZYJWZT5VZIKTQI3JC3ANCNFSM4HDWZDFA> .

[k8s-ci-robot]

@lavalamp: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

On Mon, Sep 9, 2019 at 4:05 PM Kubernetes Prow Robot <
[email protected]> wrote:

@fejta-bot https://github.com/fejta-bot: Closing this issue.

In response to this
#143 (comment):

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/close

Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:
repository.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE6BFRNUQ2ZYJWZT5VZIKTQI3JC3ANCNFSM4HDWZDFA
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.