Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BigDarkClown to cluster-autoscaler Reviewers #5492

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

BigDarkClown
Copy link
Contributor

Self-nominating for a cluster-autoscaler reviewer.

Requirements:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n February 9, 2023 16:57
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2023
@towca
Copy link
Collaborator

towca commented Feb 10, 2023

/lgtm
/approve
/hold

Bartek has authored a number of substantial PRs to the codebase, and has been thorough in reviewing PRs so far. Tagging other active approvers, any objections? @MaciekPytel @gjtempleton @x13n @feiskyer

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@x13n
Copy link
Member

x13n commented Feb 10, 2023

+1 from me!

@feiskyer
Copy link
Member

+1

@gjtempleton
Copy link
Member

+1 from me as well!

@towca
Copy link
Collaborator

towca commented Feb 14, 2023

Thanks, submitting then!
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1238e1d into kubernetes:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants