Revert base price changes from PR #3603 #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out changing those values has unexpected impact on the results of pricing expander. I think that a different base value implicitly changes the weight of pricing to the other parts of expander formula which is some cases changes CA scaling decisions. While not necessarilly wrong we shouldn't make changes like this without analyzing implications and testing, hence the revert of this part.
k8s-ci-robot
added
cncf-cla: yes
|
cc: @towca @BigDarkClown |
k8s-ci-robot
added
the
approved
BigDarkClown
approved these changes
Oct 21, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BigDarkClown, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out changing those values has unexpected impact on
the results of pricing expander. I think that a different base
value implicitly changes the weight of pricing to the
other parts of expander formula which is some cases changes CA
scaling decisions.
While not necessarilly wrong we shouldn't make changes like this
without analyzing implications and testing, hence the revert
of this part.