mig_info_provider.GetMigForInstance will now use locking when calli…

[jayantjain93]

…ng the gce api.

This is to avoid multiple gce calls for the same mig during scale down (which is done in parallel).

Which component this PR applies to?

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[jayantjain93]

/assign @MaciekPytel

[x13n]

/assign @BigDarkClown
/cc @bpineau

[k8s-ci-robot]

@x13n: GitHub didn't allow me to assign the following users: BigDarkClown.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @BigDarkClown
/cc @bpineau

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@x13n: GitHub didn't allow me to request PR reviews from the following users: bpineau.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @BigDarkClown
/cc @bpineau

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BigDarkClown]

The lock is miss-placed here, I think we should lock the GetXYZ functions instead. Also checking the cache in fillMigInstances introduced a bug, so we should not be doing that.

[BigDarkClown]

After the changes this LGTM. @MaciekPytel, could you take a look and push approve button if everything is ok?

[BigDarkClown]

/lgtm
/approve

[k8s-ci-robot]

@BigDarkClown: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[towca]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, jayantjain93, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [towca]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[towca]

/lgtm