Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hetzner public IPv4 and IPv6 configuration #5001

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

glehmann
Copy link
Contributor

@glehmann glehmann commented Jul 1, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind feature

What this PR does / why we need it:

It lets us use hetzner's new primary IP feature to disable the public IPv4/IPv6 addresses on the nodes

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added Hetzner public IPv4 and IPv6 configuration.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 1, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @glehmann!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 1, 2022
@glehmann glehmann force-pushed the hetzner-primary-ip branch from bf0882b to 3bde92b Compare July 1, 2022 15:07
@glehmann glehmann marked this pull request as ready for review July 4, 2022 13:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2022
@gjtempleton
Copy link
Member

Tagging in @LKaemmerling based on comments in #3838

@LKaemmerling Are you or someone else from Hetzner able to give this a review?

@LKaemmerling
Copy link
Contributor

This looks fine from my point of view :)

@LKaemmerling
Copy link
Contributor

/assign @aleksandra-malinowska

@gjtempleton
Copy link
Member

One more request from me actually @LKaemmerling, is there any chance we could get an OWNERS file set up for the Hetzner cloudprovider in another PR?

It doesn't even need to be member of the k8s org, we can comment out those who aren't members as with the Civo provider: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/civo/OWNERS. It'll make it easier for us to get reviews of CloudProvider specific code going forward.

@LKaemmerling
Copy link
Contributor

@gjtempleton of course i will create a PR :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, glehmann, LKaemmerling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@gjtempleton
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5ab3b25 into kubernetes:master Aug 9, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Hetzner public IPv4 and IPv6 configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants