-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hetzner public IPv4 and IPv6 configuration #5001
Conversation
Welcome @glehmann! |
bf0882b
to
3bde92b
Compare
Tagging in @LKaemmerling based on comments in #3838 @LKaemmerling Are you or someone else from Hetzner able to give this a review? |
This looks fine from my point of view :) |
/assign @aleksandra-malinowska |
One more request from me actually @LKaemmerling, is there any chance we could get an OWNERS file set up for the Hetzner cloudprovider in another PR? It doesn't even need to be member of the k8s org, we can comment out those who aren't members as with the Civo provider: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/civo/OWNERS. It'll make it easier for us to get reviews of CloudProvider specific code going forward. |
@gjtempleton of course i will create a PR :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, glehmann, LKaemmerling The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Hetzner public IPv4 and IPv6 configuration
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind feature
What this PR does / why we need it:
It lets us use hetzner's new primary IP feature to disable the public IPv4/IPv6 addresses on the nodes
Special notes for your reviewer:
Does this PR introduce a user-facing change?