Cloudprovider hetzner

[LKaemmerling]

Resubmit of #3640

Hello everyone,

I'm from the Hetzner Cloud Team and i'm happy to resubmit PR #3640 with the work of @Fgruntjes.
My collegues and i will maintain this implementation in the future. We see a high
demand from our customers for an integration into the Kubernetes Autoscaler.

So we want to thank @Fgruntjes again for his work on the initial implementation.

We will continue to improve the implementation and also support it.

cc @fhofherr

[k8s-ci-robot]

Welcome @LKaemmerling!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fhofherr]

cla signed

[k8s-ci-robot]

@LKaemmerling: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[LKaemmerling]

Hey @team, this MR is from our side basically ready. The bot says I should assign it with:

/assign @aleksandra-malinowska

[LKaemmerling]

/verify-owners

[robjuz]

Any update on this? I would love to use it I’m production.

[mwielgus]

Please remove the people outside of K8S org from the owners file and squash the commits to 1-2. Then we should be good to go.

[mwielgus]

And fix the boilerplate so that the verify scripts pass.

[LKaemmerling]

@mwielgus should be ready (now 2 commits, removed owner file and the tests should work now)

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LKaemmerling, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [mwielgus]
• hack/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[blindpirate]

Hi @LKaemmerling Thanks for the contribution, we're a Hetzner cloud user and we've run into some crashes with hetzner autoscaler, I wonder if there's repo in hetzner organization to report this issue?

[jawabuu]

@LKaemmerling @mwielgus
I'm testing out this autoscaler and it seems no kubernetes events are emitted nor nodes annotated on scaledown.
Is this expected?

[jawabuu]

From docs

Whenever Cluster Autoscaler adds or removes nodes it will create events describing this action. It will also create events for some serious errors. Below is the non-exhaustive list of events emitted by CA (new events may be added in future):
 on kube-system/cluster-autoscaler-status config map:
ScaledUpGroup - CA increased the size of node group, gives both old and new group size.
ScaleDownEmpty - CA removed a node with no pods running on it (except system pods found on all nodes).
ScaleDown - CA decided to remove a node with some pods running on it. Event includes names of all pods that will be rescheduled to drain the node.
on nodes:
ScaleDown - CA is scaling down the node. Multiple ScaleDown events may be recorded on the node, describing status of scale-down operation.
ScaleDownFailed - CA tried to remove the node, but failed. The event includes error message.