Hetzner Cloud Provider: Add Owners file #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/invalid-owners-file
mwielgus
reviewed
Aug 9, 2022
| @@ -0,0 +1,6 @@ | |||
| approvers: | |||
| - LKaemmerling | |||
There was a problem hiding this comment.
Please comment out the names (add #) so that we know who to contact and K8S org validation doesn't complain.
There was a problem hiding this comment.
@mwielgus changed :)
Signed-off-by: Lukas Kämmerling <[email protected]>
LKaemmerling
force-pushed
the
hcloud-add-code-owners-file
branch
from
7669b5a to
1038e41
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-owners-file
|
Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, LKaemmerling The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
…owners-file Hetzner Cloud Provider: Add Owners file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukas Kämmerling [email protected]
Which component this PR applies to?
Hetzner Cloud Provider
What type of PR is this?
What this PR does / why we need it:
This PR is based on the comment from #5001 (comment) . This adds @4ND3R50N and me as reviewers and approvers. We both are currently in charge of our Open Source Integrations. (Like Terraform, hcloud-go, CSI-Driver & Autoscaler)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: