Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Autoscaler: pick up the fix for k/k#114509 #5372

Closed
towca opened this issue Dec 16, 2022 · 7 comments
Closed

Cluster Autoscaler: pick up the fix for k/k#114509 #5372

towca opened this issue Dec 16, 2022 · 7 comments
Assignees
@jayantjain93
Labels
area/cluster-autoscaler kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@towca
Copy link
Collaborator

towca commented Dec 16, 2022

kubernetes/kubernetes#114509 is a bug in scheduler which affects Cluster Autoscaler at scale, introduced in k8s 1.24. It was already fixed on k/k master (kubernetes/kubernetes#114518), and the fix will be cherry-picked to 1.24 and 1.25. After that happens, and new k8s patch releases are tagged, we need to update the vendor in 1.24 and 1.25 to pick up the fix, and cut new CA patch versions.
@towca towca added area/cluster-autoscaler kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Dec 16, 2022
@towca towca changed the title Cluster Autoscaler: pick up the fix for k/k #114509 Cluster Autoscaler: pick up the fix for k/k#114509 Dec 16, 2022
@Bryce-Soghigian
Copy link
Member

Looks like it was cherry-picked here
kubernetes/kubernetes#114524
kubernetes/kubernetes#114525

So we are just waiting on the patch release.https://kubernetes.io/releases/patch-releases/#1-25

@jayantjain93 jayantjain93 mentioned this issue Jan 25, 2023
Merged
jayantjain93 added a commit to jayantjain93/autoscaler that referenced this issue Jan 25, 2023
@jayantjain93
update vendor to v1.26.1 due to kubernetes#5372
5e378d7
@jayantjain93 jayantjain93 mentioned this issue Jan 25, 2023
Merged
jayantjain93 added a commit to jayantjain93/autoscaler that referenced this issue Jan 25, 2023
@jayantjain93
update vendor to v1.25.6 due to kubernetes#5372
f7ab4da
@jayantjain93 jayantjain93 mentioned this issue Jan 25, 2023
Merged
jayantjain93 added a commit to jayantjain93/autoscaler that referenced this issue Jan 25, 2023
@jayantjain93
update vendor to v1.24.10 due to kubernetes#5372
75d6c8f
jayantjain93 added a commit to jayantjain93/autoscaler that referenced this issue Jan 25, 2023
@jayantjain93
update vendor to v1.25.6 due to kubernetes#5372
f3b4eba
@jayantjain93 jayantjain93 mentioned this issue Jan 25, 2023
Merged
@jayantjain93
Copy link
Contributor

/assign @jayantjain93

@jayantjain93
Copy link
Contributor

PRs are open for all affected versions.

k8s-ci-robot added a commit that referenced this issue Jan 25, 2023
@k8s-ci-robot
Merge pull request #5445 from jayantjain93/scheduler-fix-release-1.26
29ac211 
update vendor to v1.26.1 due to #5372
k8s-ci-robot added a commit that referenced this issue Jan 25, 2023
@k8s-ci-robot
Merge pull request #5446 from jayantjain93/scheduler-fix-release-1.25
479a31d 
update vendor to v1.25.6 due to #5372
k8s-ci-robot added a commit that referenced this issue Jan 25, 2023
@k8s-ci-robot
Merge pull request #5447 from jayantjain93/scheduler-fix-release-1.24
7d5b472 
update vendor to v1.24.10 due to #5372
@jayantjain93
Copy link
Contributor

/fixed

joelsmith pushed a commit to joelsmith/autoscaler that referenced this issue Feb 13, 2023
@jayantjain93 @joelsmith
UPSTREAM: <drop>: update vendor to v1.26.1 due to kubernetes#5372
820658c 
This can drop when rebasing 1.27+
joelsmith pushed a commit to joelsmith/autoscaler that referenced this issue Feb 13, 2023
@jayantjain93 @joelsmith
UPSTREAM: <drop>: update vendor to v1.26.1 due to kubernetes#5372
a1efe30 
This can drop when rebasing 1.27+
joelsmith pushed a commit to joelsmith/autoscaler that referenced this issue Feb 14, 2023
@jayantjain93 @joelsmith
UPSTREAM: <drop>: update vendor to v1.26.1 due to kubernetes#5372
4814c63 
This can drop when rebasing 1.27+
@elankath elankath mentioned this issue Apr 11, 2023
Merged
elankath added a commit to gardener/autoscaler that referenced this issue Apr 13, 2023
@elankath @BigDarkClown
@k8s-ci-robot @towca @jayantjain93 @gandhipr @MaciekPytel
Sync upstream until 1.26.2 (#212)
ac0a14a 
* Move PredicateChecker initialization before processors initialization

* Cluster Autoscaler 1.26.1

* update vendor to v1.26.1 due to kubernetes#5372

* baseURI for skuClient based on cloud

* Update go version to 1.19.7

This is following-up on Kubernetes 1.26 bumping the go version.

* Update vendor to kubernetes 1.26.3

Also updated CA version to 1.26.2

* revendored with ./hack/update-vendor.sh 1.26.1

* back to ./hack/update-vendor.sh 1.26.3 after IT success

* const ClusterAutoscalerVersion = "1.26.1

* mod sync_changes mentioning k8s.io pkg upgrades

---------

Co-authored-by: Bartłomiej Wróblewski <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
Co-authored-by: Kuba Tużnik <[email protected]>
Co-authored-by: Jayant Jain <[email protected]>
Co-authored-by: Prachi Gandhi <[email protected]>
Co-authored-by: Maciek Pytel <[email protected]>
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2023
@towca
Copy link
Collaborator Author

towca commented Apr 26, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@towca: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayantjain93 jayantjain93

Labels
area/cluster-autoscaler kind/regression Categorizes issue or PR as related to a regression from a prior release. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jayantjain93 @towca @k8s-ci-robot @Bryce-Soghigian @k8s-triage-robot