Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vendor to v1.27.0-alpha.1 #5443

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

jayantjain93
Copy link
Contributor

@jayantjain93 jayantjain93 commented Jan 25, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #5397

5372

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and x13n January 25, 2023 14:19
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2023
@jayantjain93 jayantjain93 force-pushed the revendor-scheduler-bug branch from d0a5b75 to c7ee337 Compare January 25, 2023 17:08
@towca
Copy link
Collaborator

towca commented Jan 25, 2023

/lgtm
/approve
/hold

Looks good, holding for the nit.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayantjain93, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@towca
Copy link
Collaborator

towca commented Jan 25, 2023

This fixes #5397.

@jayantjain93
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2023
…string]*Status to *Status.

The func returns after the first failed plugin.

Augmented schedulerbased.go to reflect this change.
@jayantjain93 jayantjain93 force-pushed the revendor-scheduler-bug branch from c7ee337 to 32c6bbc Compare January 25, 2023 17:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@towca
Copy link
Collaborator

towca commented Jan 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5d55f99 into kubernetes:master Jan 25, 2023
@jayantjain93 jayantjain93 deleted the revendor-scheduler-bug branch January 25, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to scheduler framework interface changes in RunFilterPlugins
3 participants