Sync upstream cluster-autoscaler-release-1.26 for patch #212

elankath · 2023-04-11T08:44:31Z

What this PR does / why we need it:
Syncs the autoscaler with upstream v1.26.2

Which issue(s) this PR fixes:
Fixes #211

Special notes for your reviewer:
NOTE: This fixes upstream autoscaler issue: kubernetes#5372

Release note:

Synced the changes till v1.26.2 of upstream autoscaler release branch: cluster-autoscaler-release-1.26
Includes fix for https://github.com/kubernetes/autoscaler/issues/5372

…ick-of-#5388-upstream-cluster-autoscaler-release-1.26 Automated cherry pick of kubernetes#5388: Move PredicateChecker initialization before processors

Cluster Autoscaler 1.26.1

…lease-1.26 update vendor to v1.26.1 due to kubernetes#5372

…pick-cloud-based-uri-skuClient-1.26 baseURI for skuClient based on cloud cherry-pick kubernetes#5603

This is following-up on Kubernetes 1.26 bumping the go version.

Also updated CA version to 1.26.2

Cluster Autoscaler 1.26.2

CLAassistant · 2023-04-11T08:44:40Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 7 committers have signed the CLA.

✅ elankath
❌ k8s-ci-robot
❌ BigDarkClown
❌ towca
❌ gandhipr
❌ MaciekPytel
❌ jayantjain93
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

gardener-robot · 2023-04-11T08:44:41Z

@elankath You need rebase this pull request with latest master branch. Please check.

gardener-robot-ci-3 · 2023-04-11T08:45:19Z

Thank you @elankath for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

elankath · 2023-04-12T04:50:56Z

Integration tests now passing after re-vendoring to 1.26.1

...
Ran 11 of 11 Specs in 851.680 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 0 Skipped

cluster-autoscaler/go.mod

himanshu-kun

just one tiny change requested, o.w. all looks good

elankath · 2023-04-13T08:58:37Z

just one tiny change requested, o.w. all looks good

made changes mentioning upgrades in k8s.io packages in sync_changes.
latest IT run passed.

himanshu-kun

/lgtm

BigDarkClown and others added 12 commits January 3, 2023 14:46

Move PredicateChecker initialization before processors initialization

7fef308

Merge pull request kubernetes#5396 from johngmyers/automated-cherry-p…

a2b7afa

…ick-of-#5388-upstream-cluster-autoscaler-release-1.26 Automated cherry pick of kubernetes#5388: Move PredicateChecker initialization before processors

Cluster Autoscaler 1.26.1

8d7f213

Merge pull request kubernetes#5398 from towca/jtuznik/1.26.1

f48095c

Cluster Autoscaler 1.26.1

update vendor to v1.26.1 due to kubernetes#5372

5e378d7

Merge pull request kubernetes#5445 from jayantjain93/scheduler-fix-re…

29ac211

…lease-1.26 update vendor to v1.26.1 due to kubernetes#5372

baseURI for skuClient based on cloud

9097d25

Merge pull request kubernetes#5604 from gandhipr/prachigandhi/cherry-…

96d43c4

…pick-cloud-based-uri-skuClient-1.26 baseURI for skuClient based on cloud cherry-pick kubernetes#5603

Update go version to 1.19.7

317283b

This is following-up on Kubernetes 1.26 bumping the go version.

Update vendor to kubernetes 1.26.3

b7c7236

Also updated CA version to 1.26.2

Merge pull request kubernetes#5612 from MaciekPytel/ca_1_26_2

6657ca5

Cluster Autoscaler 1.26.2

sync aainst upstream cluster-autoscaler-release-1.26 till 1.26.2

c55f36b

elankath requested review from himanshu-kun, unmarshall, rishabh-11 and a team as code owners April 11, 2023 08:44

gardener-robot added the needs/rebase Needs git rebase label Apr 11, 2023

gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Apr 11, 2023

elankath closed this Apr 11, 2023

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 11, 2023

elankath reopened this Apr 11, 2023

gardener-robot added status/accepted Issue was accepted as something we need to work on and removed status/closed Issue is closed (either delivered or triaged) labels Apr 11, 2023

elankath changed the base branch from machine-controller-manager-provider to rel-v1.26 April 11, 2023 08:49

elankath assigned himanshu-kun Apr 11, 2023

gardener-robot removed the needs/rebase Needs git rebase label Apr 12, 2023

elankath assigned himanshu-kun and elankath and unassigned elankath and himanshu-kun Apr 12, 2023

himanshu-kun suggested changes Apr 12, 2023

View reviewed changes

cluster-autoscaler/go.mod Outdated Show resolved Hide resolved

back to ./hack/update-vendor.sh 1.26.3 after IT success

29ad117

elankath assigned himanshu-kun and unassigned elankath Apr 13, 2023

elankath added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2023

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 13, 2023

const ClusterAutoscalerVersion = "1.26.1

a552d47

himanshu-kun suggested changes Apr 13, 2023

View reviewed changes

mod sync_changes mentioning k8s.io pkg upgrades

ae66753

himanshu-kun approved these changes Apr 13, 2023

View reviewed changes

gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Apr 13, 2023

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 13, 2023

elankath merged commit ac0a14a into gardener:rel-v1.26 Apr 13, 2023

elankath deleted the sync-rel-v1.26 branch April 13, 2023 11:14

gardener-robot added status/closed Issue is closed (either delivered or triaged) and removed status/accepted Issue was accepted as something we need to work on labels Apr 13, 2023

himanshu-kun assigned elankath and unassigned himanshu-kun Apr 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync upstream cluster-autoscaler-release-1.26 for patch #212

Sync upstream cluster-autoscaler-release-1.26 for patch #212

elankath commented Apr 11, 2023

CLAassistant commented Apr 11, 2023 •

edited

Loading

gardener-robot commented Apr 11, 2023

gardener-robot-ci-3 commented Apr 11, 2023

elankath commented Apr 12, 2023

himanshu-kun left a comment

elankath commented Apr 13, 2023 •

edited

Loading

himanshu-kun left a comment

Sync upstream cluster-autoscaler-release-1.26 for patch #212

Sync upstream cluster-autoscaler-release-1.26 for patch #212

Conversation

elankath commented Apr 11, 2023

CLAassistant commented Apr 11, 2023 • edited Loading

gardener-robot commented Apr 11, 2023

gardener-robot-ci-3 commented Apr 11, 2023

elankath commented Apr 12, 2023

himanshu-kun left a comment

Choose a reason for hiding this comment

elankath commented Apr 13, 2023 • edited Loading

himanshu-kun left a comment

Choose a reason for hiding this comment

CLAassistant commented Apr 11, 2023 •

edited

Loading

elankath commented Apr 13, 2023 •

edited

Loading