Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testGenericJob on BaseWebhook tests. #3438

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Nov 4, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use testGenericJob on testing BaseWebhook.

Which issue(s) this PR fixes:

Part of #3372

Special notes for your reviewer:

This is prepare PR for #3414.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc November 4, 2024 16:58
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 446c4dd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6728fd3de190f20008006e58
😎 Deploy Preview https://deploy-preview-3438--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 4, 2024 17:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y November 4, 2024 17:15
@mbobrovskyi mbobrovskyi changed the title Use testGenericJob on testing BaseWebhook. Use testGenericJob on BaseWebhook tests. Nov 4, 2024
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ddb98fe77c25f2a48d6f911bca25e4e99daab8ef

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 38a1060 into kubernetes-sigs:main Nov 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Nov 5, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/use-test-generic-job-on-base-webhook branch November 5, 2024 08:17
@mbobrovskyi mbobrovskyi restored the cleanup/use-test-generic-job-on-base-webhook branch November 5, 2024 08:22
@mbobrovskyi mbobrovskyi deleted the cleanup/use-test-generic-job-on-base-webhook branch November 5, 2024 08:22
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants