Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: Support Kubeflow. #3414

Merged
merged 2 commits into from
Nov 5, 2024
Merged

TAS: Support Kubeflow. #3414

merged 2 commits into from
Nov 5, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

TAS: Support Kubeflow.

Which issue(s) this PR fixes:

Part of #3372

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 1, 2024
@mbobrovskyi mbobrovskyi marked this pull request as draft November 1, 2024 13:35
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from mimowo and trasc November 1, 2024 13:35
@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 534219c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6729d5b4b7a0790008ec2790

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 1, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch from 3ac1ad4 to ee859f1 Compare November 1, 2024 14:58
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch from ee859f1 to 55aaede Compare November 1, 2024 15:22
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch 4 times, most recently from e1e3d6c to 1b3f079 Compare November 4, 2024 09:05
@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 4, 2024 16:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y November 4, 2024 16:00
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch from 1b3f079 to ed0a890 Compare November 4, 2024 16:12
@mbobrovskyi mbobrovskyi mentioned this pull request Nov 4, 2024
Merged
@mbobrovskyi mbobrovskyi marked this pull request as draft November 5, 2024 05:47
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch from ed0a890 to 9f01454 Compare November 5, 2024 06:35
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/tas-support-kubeflow branch from 9f01454 to 67100ba Compare November 5, 2024 07:28
@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 5, 2024 08:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/cc @mimowo

ack

@mbobrovskyi mbobrovskyi mentioned this pull request Nov 5, 2024
Merged
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/lgtm
/approve
In a follow up please mark all the integration tests (except for one kubeflow Job) as redundant.
/hold
in case @tenzen-y has some more comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6eca492a2eb6fed0453dbe40547b615e8276479

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/hold cancel
To unblock other PRs pending for the release. @tenzen-y please feel free to still comment on the PR, and we will address any comments in follow up PRs.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/hold
as I just got a ping on slack, let's wait for the comments

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@mimowo
Copy link
Contributor

mimowo commented Nov 5, 2024

/hold cancel
ok I got info @tenzen-y will review later today. In the meanwhile I think it is safe to merge to unblock #3449 and so we can start preparing the release notes

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit b3c53d5 into kubernetes-sigs:main Nov 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Nov 5, 2024
@mbobrovskyi mbobrovskyi deleted the feature/tas-support-kubeflow branch November 5, 2024 13:25
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
@mbobrovskyi @kannon92
TAS: Support Kubeflow. (kubernetes-sigs#3414)
4af1d77 
* TAS: Support Kubeflow.

* Test ValidateOnCreate and ValidateOnUpdate on BaseWebHook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mbobrovskyi @mimowo @k8s-ci-robot @tenzen-y