Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS: support all Job CRDs (including Pods) #3372

Closed
mimowo opened this issue Oct 30, 2024 · 7 comments
Closed

TAS: support all Job CRDs (including Pods) #3372

mimowo opened this issue Oct 30, 2024 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mimowo
Copy link
Contributor

mimowo commented Oct 30, 2024

What would you like to be added:

Add support for all Job CRDs. Currently we have Job and JobSet covered.

This consists two parts:

  • computation of the TopologyRequest as in here
  • validation as in here

The above should be unit tested (new TestPodSets function per CRD).
I suggest one PR per CRD so that we can release at any point, even if not all are done.

Why is this needed:

This is part of #2724 which can be easily separated as another task.
To support TAS for all Job CRDs, it is a point of the plan in the spreadsheet

@mimowo mimowo added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 30, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Oct 30, 2024

/assign @mbobrovskyi
cc @PBundyra @tenzen-y

@tenzen-y
Copy link
Member

/assign @mbobrovskyi cc @PBundyra @tenzen-y

+1
We can just move all Job support to the Alpha stage in the KEP.

@mimowo
Copy link
Contributor Author

mimowo commented Oct 31, 2024

I have also synced with @mbobrovskyi we will add a basic integration test per integration. From Job creation to create workload assignment

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Oct 31, 2024

/reopen

Oops. Added fixes by mistake on #3402.

@k8s-ci-robot k8s-ci-robot reopened this Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

@mbobrovskyi: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mimowo
Copy link
Contributor Author

mimowo commented Nov 5, 2024

/close
Up to my knowledge we have all CRDs covered

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closing this issue.

In response to this:

/close
Up to my knowledge we have all CRDs covered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants