feat(offline): Improve generate_list.sh using ansible (#8537) #8538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using ansible (kubernetes-sigs#8537) Use jinja2 template and ansible to expand variables.
k8s-ci-robot
added
kind/feature
|
Hi @tmurakam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
Nice work! /cc @cristicalin |
k8s-ci-robot
added
ok-to-test
cristicalin
approved these changes
Feb 14, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, tmurakam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Quehenr
pushed a commit
to Quehenr/unstable-laboratory-infrastructure-kubespray
that referenced
this pull request
Feb 18, 2022
* master: Configure Etcd container_manager explicitly (kubernetes-sigs#8521) Fix print_hostnames of inventory.py (kubernetes-sigs#8554) Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550) nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539) Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530) [calico] upgrade release checksums (kubernetes-sigs#8544) Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534) add support for Dual Stack node InternalIP (kubernetes-sigs#8542) terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524) add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541) implement download mirrors support (kubernetes-sigs#8474) Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516) feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523) Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519) Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Mar 5, 2022
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) Use jinja2 template and ansible to expand variables.
tmurakam
added a commit
to tmurakam/kubespray
that referenced
this pull request
Mar 5, 2022
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) Use jinja2 template and ansible to expand variables.
sakuraiyuta
pushed a commit
to sakuraiyuta/kubespray
that referenced
this pull request
Apr 16, 2022
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) Use jinja2 template and ansible to expand variables.
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 29, 2023
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) Use jinja2 template and ansible to expand variables.
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 21, 2023
… using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) Use jinja2 template and ansible to expand variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve generate_list.sh to generate offline file list using ansible (#8537)
Use jinja2 template and ansible to expand variables.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Current contrib/offline/generate_list.sh parses some yaml files and expands variables without using ansible.
This is a bit of tough task, and hard to maintain.
It should make use of jinja2 template and ansible to expand variables.
Which issue(s) this PR fixes:
Fixes #8537
Special notes for your reviewer:
Does this PR introduce a user-facing change?: