Allow to specify a source address for metallb peerings, and target on… #8534
Conversation
…ly some nodes using node selectors
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @hightoxicity. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
| {% endif %} | ||
| {% if peer.node_selectors is defined %} | ||
| node-selectors: | ||
| {{ peer.node_selectors | to_yaml(indent=2, width=1337) | indent(8) }} |
There was a problem hiding this comment.
According to https://metallb.universe.tf/configuration/#configuring-the-bgp-source-address the above change seems good for me.
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, hightoxicity The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
* master: Configure Etcd container_manager explicitly (kubernetes-sigs#8521) Fix print_hostnames of inventory.py (kubernetes-sigs#8554) Fix etcd_events not getting upgraded in upgrade-cluster.yml (kubernetes-sigs#8550) nerdctl: upgrade to 0.16.1 (kubernetes-sigs#8539) Allow pausing after upgrade but before uncordon (kubernetes-sigs#8530) [calico] upgrade release checksums (kubernetes-sigs#8544) Allow to specify a source address for metallb peerings, and target only some nodes using node selectors (kubernetes-sigs#8534) add support for Dual Stack node InternalIP (kubernetes-sigs#8542) terraform/gcp: Allow to change extra disk types (kubernetes-sigs#8524) add support for Calico IP6_AUTODETECTION_METHOD (kubernetes-sigs#8541) implement download mirrors support (kubernetes-sigs#8474) Fix: Error when creating subnets more than AZ (kubernetes-sigs#8516) feat(offline): Improve generate_list.sh to generate offline file list using ansible (kubernetes-sigs#8537) (kubernetes-sigs#8538) docs: Update offline-environment.md for containerd (kubernetes-sigs#8520) (kubernetes-sigs#8523) Change Cilium setting identity_allocation_mode to cilium_identity_allocation_mode (kubernetes-sigs#8519) Fix wrong port name in metallb.yml.j2 (kubernetes-sigs#8510)
…ly some nodes using node selectors (kubernetes-sigs#8534)
…ly some nodes using node selectors (kubernetes-sigs#8534)
…ly some nodes using node selectors (kubernetes-sigs#8534)
What type of PR is this?
/kind feature
What this PR does / why we need it:
We are currently using metallb and its speaker to make BGP announces of load balancer prefixes in a calico and a per node peering with its TOR context (we use the one AS per rack peering with ibgp + route reflector). Metallb speaker is a good component to make announces with another ASN (ebgp between node and metallb), in this config, each node must be configured to have a specific metallb peering, to accomplish this, we have to specify the source address in 127.0.0.1 because the calico's bird is already taking the node IP to peer with the TOR. Second thing: we must be able to target specific node to assign for each node a different ASN to peer with.
Does this PR introduce a user-facing change?:
NONE